From owner-svn-src-all@FreeBSD.ORG  Mon May 25 13:57:30 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8B025DF7;
 Mon, 25 May 2015 13:57:30 +0000 (UTC)
 (envelope-from melifaro@ipfw.ru)
Received: from forward14h.cmail.yandex.net (forward14h.cmail.yandex.net
 [IPv6:2a02:6b8:0:f35::9f])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "forwards.mail.yandex.net",
 Issuer "Certum Level IV CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 41318656;
 Mon, 25 May 2015 13:57:30 +0000 (UTC)
 (envelope-from melifaro@ipfw.ru)
Received: from web7h.yandex.ru (web7h.yandex.ru [84.201.186.36])
 by forward14h.cmail.yandex.net (Yandex) with ESMTP id 735D02175E;
 Mon, 25 May 2015 16:57:10 +0300 (MSK)
Received: from 127.0.0.1 (localhost [127.0.0.1])
 by web7h.yandex.ru (Yandex) with ESMTP id A36ED6921425;
 Mon, 25 May 2015 16:57:09 +0300 (MSK)
Received: by web7h.yandex.ru with HTTP;
	Mon, 25 May 2015 16:57:09 +0300
From: Alexander V. Chernikov <melifaro@freebsd.org>
Envelope-From: melifaro@ipfw.ru
To: John Baldwin <jhb@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
In-Reply-To: <1698551.fhQlKrx2sg@ralph.baldwin.cx>
References: <201505241124.t4OBOFe6030452@svn.freebsd.org>
 <1698551.fhQlKrx2sg@ralph.baldwin.cx>
Subject: Re: svn commit: r283364 - head/sys/sys
MIME-Version: 1.0
Message-Id: <2823711432562229@web7h.yandex.ru>
X-Mailer: Yamail [ http://yandex.ru ] 5.0
Date: Mon, 25 May 2015 16:57:09 +0300
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=utf-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 May 2015 13:57:30 -0000

25.05.2015, 14:45, "John Baldwin" <jhb@freebsd.org>:
> On Sunday, May 24, 2015 11:24:15 AM Alexander V. Chernikov wrote:
>>  Author: melifaro
>>  Date: Sun May 24 11:24:14 2015
>>  New Revision: 283364
>>  URL: https://svnweb.freebsd.org/changeset/base/283364
>>
>>  Log:
>>    Fix SIOCGI2C structure requirement.
>>
>>    In reality, SIOCGI2C ioctl requires struct ifreq as many other
>>    ioctls. Doing copyin() on (significantly) larger struct ifstat sometimes
>>    triggered EFAULT.
>>
>>    Reported by: Olivier Cochard-Labbé <olivier at cochard.me>
>>    MFC after: 1 week
>
> Note that this breaks the ABI.  You may wish to add a SIOCGI2C_OLD that
In general, yes. Since this was not merged to -stable and I'm mostly sure that ifconfig
is the only user - this is most likely OK.
> still uses the larger struct so that old programs continue to work.  OTOH,
> they were only working by accident before.  If we expect that no code
Well, yes. I'm wondering why this worked at all (copyout tried to get 8XX bytes instead of 32).
> outside of ifconfig is using this yet, then it is probably ok to let this
> slide.
>
> --
> John Baldwin