From owner-svn-ports-all@freebsd.org  Fri Jul 22 04:56:28 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7CD8BA1730;
 Fri, 22 Jul 2016 04:56:28 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 530CB1973;
 Fri, 22 Jul 2016 04:56:27 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 91a018c9
 TLS version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Thu, 21 Jul 2016 22:55:58 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: svn commit: r418889 - in head/deskutils: . copyq
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <20160722044657.GC37437@FreeBSD.org>
Date: Thu, 21 Jul 2016 22:56:17 -0600
Cc: Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <91496634-0037-4256-951C-F8A8ABF284A9@adamw.org>
References: <201607211847.u6LIluTh087613@repo.freebsd.org>
 <20160722044657.GC37437@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2016 04:56:29 -0000

> On 21 Jul, 2016, at 22:46, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
>=20
> On Thu, Jul 21, 2016 at 06:47:56PM +0000, Kris Moore wrote:
>> New Revision: 418889
>> URL: https://svnweb.freebsd.org/changeset/ports/418889
>>=20
>> Log:
>>  CopyQ is advanced clipboard manager with editing and scripting =
features.
>>=20
>>  WWW: https://github.com/hluk/CopyQ
>>=20
>> [...]
>> +USE_XORG+=3D	x11 xfixes xtst
>=20
> What's the reason for +=3D here?
>=20
>> +USE_QT5=3D        core gui network svg multimedia imageformats \
>=20
> Spaces were used in this line instead of proper tab.
>=20
>> +USE_GL+=3D	gl
>=20
> Bogus +=3D again.
>=20
>> +USES=3D           qmake
>=20
> Spaces again; also it's better to place more generic USES *before* =
specific
> USE_FOO knobs.
>=20
>> +PLIST_FILES=3D	bin/copyq
>=20
> PLIST-related knobs should be among the last ones (after USE* knobs, =
but
> before OPTIONS* knobs).

AFAIK we've never specified ordering after _DEPENDS. FWIW, Kris's =
ordering makes sense to me; the variables are ordered by decreasing =
probability of future modification. Though I do agree about all the =
+=3D's.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org