From owner-cvs-all Sun Jul 14 9:58:45 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB07D37B400; Sun, 14 Jul 2002 09:58:40 -0700 (PDT) Received: from iguana.icir.org (iguana.icir.org [192.150.187.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88D8143E6E; Sun, 14 Jul 2002 09:58:40 -0700 (PDT) (envelope-from rizzo@iguana.icir.org) Received: (from rizzo@localhost) by iguana.icir.org (8.11.6/8.11.3) id g6EGwe377587; Sun, 14 Jul 2002 09:58:40 -0700 (PDT) (envelope-from rizzo) Date: Sun, 14 Jul 2002 09:58:40 -0700 From: Luigi Rizzo To: Mark Peek Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/picobsd/build write_mfs_in_kernel.c Message-ID: <20020714095839.H74633@iguana.icir.org> References: <200207141209.g6EC9XBL099971@freefall.freebsd.org> <20020714093834.E74633@iguana.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from mp@FreeBSD.org on Sun, Jul 14, 2002 at 09:50:05AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jul 14, 2002 at 09:50:05AM -0700, Mark Peek wrote: > At 9:38 AM -0700 7/14/02, Luigi Rizzo wrote: > >i guess that those in need (assuming they exist) will find out and > >complain and possibly we will move this code to a more appropriate > >place. Where, i just have no idea. > > Well, I guess you could say that I complained. I'll send a request to > the cvsmeisters for a repo copy to (yet) another location. you are not in need -- you just asked who could be using it and did not positively mention anyone. Not that i am opposed to keeping it, just i do not see any use... > >In any case the dd hack is as much of a hack as the one in > >write_mfs_in_kernel.c, and it is not bad at all: > > > > set `strings -at d kernel | grep "MFS Filesystem goes here"` > > mfs_ofs=$(($1 + 8192)) > > dd if=${c_fs} ibs=8192 iseek=1 of=kernel obs=${mfs_ofs} \ > > oseek=1 conv=notrunc > > Well, write_mfs_in_kernel does a bit more error checking to ensure > the user isn't shooting themselves in the foot. the only additional check is that the area where you would 'dd' the data is all-zero. You still have plenty of ways to shoot yourself in the foot by passing an invalid mfs image as argument (and if the kernel area is non-zero, you _are_ passing an invalid argument, the kernel in this case). cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message