From owner-freebsd-ports Fri Feb 22 5:10:27 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id D4B8337B404 for ; Fri, 22 Feb 2002 05:10:00 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g1MDA0Y69292; Fri, 22 Feb 2002 05:10:00 -0800 (PST) (envelope-from gnats) Received: from rwcrmhc54.attbi.com (rwcrmhc54.attbi.com [216.148.227.87]) by hub.freebsd.org (Postfix) with ESMTP id 77A3C37B402; Fri, 22 Feb 2002 05:03:56 -0800 (PST) Received: from blossom.cjclark.org ([12.234.91.48]) by rwcrmhc54.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020222130351.TQZM1214.rwcrmhc54.attbi.com@blossom.cjclark.org>; Fri, 22 Feb 2002 13:03:51 +0000 Received: (from cjc@localhost) by blossom.cjclark.org (8.11.6/8.11.6) id g1MD3pj97767; Fri, 22 Feb 2002 05:03:51 -0800 (PST) (envelope-from cjc) Message-Id: <200202221303.g1MD3pj97767@blossom.cjclark.org> Date: Fri, 22 Feb 2002 05:03:51 -0800 (PST) From: "Crist J. Clark" To: FreeBSD-gnats-submit@freebsd.org Cc: obrien@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/35207: [PATCH] nmap port adds /usr/local/share/gnome directories Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 35207 >Category: ports >Synopsis: [PATCH] nmap port adds /usr/local/share/gnome directories >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Feb 22 05:10:00 PST 2002 >Closed-Date: >Last-Modified: >Originator: Crist J. Clark >Release: FreeBSD 4.5-STABLE i386 >Organization: >Environment: FreeBSD ports last updated yesterday >Description: The nmap port, ports/security/nmap, adds the following directories to the system when installed, $ ls -R /usr/local/share/gnome apps /usr/local/share/gnome/apps: Utilities /usr/local/share/gnome/apps/Utilities: (Assuming the default, /usr/local, PREFIX.) These directories are not necessary and not listed in the pkg-plist or +CONTENTS. >How-To-Repeat: For testing this, I just did, $ make DISTDIR=/var/tmp PREFIX=/var/tmp/nmap WKRDIRPREFIX=/var/tmp install And found, $ ls /var/tmp/nmap/share gnome nmap Examining the Makefile clearly shows why this happens. >Fix: I think the nmap port should not try to install the nmapfe stuff. Note that this does not break the nmapfe port (that I can tell). Index: ports/security/nmap/files/patch-aa =================================================================== RCS file: /export/ncvs/ports/security/nmap/files/patch-aa,v retrieving revision 1.12 diff -u -r1.12 patch-aa --- ports/security/nmap/files/patch-aa 28 May 2001 01:01:19 -0000 1.12 +++ ports/security/nmap/files/patch-aa 22 Feb 2002 12:57:50 -0000 @@ -7,7 +7,7 @@ +#INCLS = -I$(LIBPCAPDIR) DEFS = @DEFS@ -DNMAP_VERSION=\"$(NMAP_VERSION)\" -DNMAP_NAME=\"$(NMAP_NAME)\" -DNMAP_URL=\"$(NMAP_URL)\" -DNMAP_PLATFORM=\"$(NMAP_PLATFORM)\" -DNMAPDATADIR=\"$(nmapdatadir)\" CFLAGS = -g @CFLAGS@ $(CCOPT) $(DEFS) $(INCLS) -@@ -171,9 +171,13 @@ +@@ -171,9 +171,12 @@ $(MAKEDEPEND) $(INCLS) -s "# DO NOT DELETE" -- $(DEFS) -- $(SRCS) -install: $(TARGET) @@ -21,6 +21,5 @@ +install: $(TARGET) + $(SHTOOL) mkdir -f -p -m 755 $(bindir) $(mandir)/man1 $(nmapdatadir) + $(INSTALL) -c -m 755 nmap $(bindir)/nmap -+ -$(MAKE) install-nmapfe $(INSTALL) -c -m 644 docs/$(TARGET).1 $(mandir)/man1/$(TARGET).1 $(INSTALL) -c -m 644 nmap-os-fingerprints $(nmapdatadir)/nmap-os-fingerprints >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message