From owner-svn-src-all@freebsd.org Wed Aug 22 17:40:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 049F71090212; Wed, 22 Aug 2018 17:40:52 +0000 (UTC) (envelope-from ctuffli@gmail.com) Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 92E4E80A93; Wed, 22 Aug 2018 17:40:51 +0000 (UTC) (envelope-from ctuffli@gmail.com) Received: by mail-oi0-f47.google.com with SMTP id z185-v6so4131327oia.5; Wed, 22 Aug 2018 10:40:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eBRGE9WI+uiJQHYeD0XNJBzORW+NLwASJcg6IDWDKac=; b=Sl2+8TZHwCOjRli+YF2CUBqEIq0dTVarAfz7uhvDc52YqKFDM+wQ0DLKJQHwVPfu2J WaE/lPaRYtoUdzZ0PoqySGtVksF2rp5BX9e02jNrAxIqFLr5a5tCB+gy7Qe5O80Nnwcr aOj4PzTjxtDE03otjYbqlvr7L9v3Ghpu5bF1h5SAY+oL/p5xzeuSpMrHW25MR/70qbZf thmiToYXkBGIbFVaGpRXI71/J67WEtALiyZsUq1WAP9HySDEZy729Q2sCwgilc/MPkv3 q8xKBZ//F9osRuPMdDFlYndCk75WQksS9ipcipapFUEZdsvoKh4CiOOUr5r0n6xRwRel eAsQ== X-Gm-Message-State: APzg51CVnwYrqYLHVY/kjs/SC2mkpOK8uQVsvSKsZTDDVfZxo1FG4N56 4y/HDVpVMn9dlA10uSjr7O6R5eUc X-Google-Smtp-Source: ANB0Vda48l5/TljgfDjL+KTi75Azu0R5FMu6Rn8rPbzjvWurIqvxSWji4OUxkh8/PC0WsWzhnaX0mw== X-Received: by 2002:aca:6b87:: with SMTP id g129-v6mr4033043oic.88.1534948985160; Wed, 22 Aug 2018 07:43:05 -0700 (PDT) Received: from mail-oi0-f41.google.com (mail-oi0-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id m7-v6sm1284874oia.32.2018.08.22.07.43.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Aug 2018 07:43:04 -0700 (PDT) Received: by mail-oi0-f41.google.com with SMTP id z185-v6so3105659oia.5; Wed, 22 Aug 2018 07:43:04 -0700 (PDT) X-Received: by 2002:a54:4d86:: with SMTP id y6-v6mr4322249oix.261.1534948984339; Wed, 22 Aug 2018 07:43:04 -0700 (PDT) MIME-Version: 1.0 References: <201808220429.w7M4TOsT095655@repo.freebsd.org> In-Reply-To: From: Chuck Tuffli Date: Wed, 22 Aug 2018 07:42:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r338182 - in head: sbin/nvmecontrol sys/cam/nvme sys/dev/mpr sys/dev/nvme sys/sys usr.sbin/bhyve To: lists@eitanadler.com Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 17:40:52 -0000 On Wed, Aug 22, 2018 at 6:10 AM Eitan Adler wrote: > > On Tue, 21 Aug 2018 at 21:29, Chuck Tuffli wrote: > > > > Author: chuck > > Date: Wed Aug 22 04:29:24 2018 > > New Revision: 338182 > > URL: https://svnweb.freebsd.org/changeset/base/338182 > > > > Log: > > Make NVMe compatible with the original API > > This breaks sysutils/smartmontools. Would you be willing to patch the > port and/or submitting a diff upstream? Technically, the original big-endian changes broke smartmontools, but I understand your point and am happy to provide a patch. Since I don't have a sense for how much backwards compatibility they want, I've contacted the maintainer to give them a heads up that this change happened and will see where they want to go. --chuck