From owner-svn-src-all@FreeBSD.ORG Fri Jan 20 03:36:34 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74037106566C; Fri, 20 Jan 2012 03:36:34 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 160788FC13; Fri, 20 Jan 2012 03:36:32 +0000 (UTC) Received: from alph.allbsd.org ([IPv6:2001:2f0:104:e010:862b:2bff:febc:8956]) (authenticated bits=128) by mail.allbsd.org (8.14.4/8.14.4) with ESMTP id q0K3aK4A045413; Fri, 20 Jan 2012 12:36:30 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.14.4/8.14.4) with ESMTP id q0K3aI2H084998; Fri, 20 Jan 2012 12:36:20 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Fri, 20 Jan 2012 12:32:56 +0900 (JST) Message-Id: <20120120.123256.1432718473132856309.hrs@allbsd.org> To: eadler@FreeBSD.org From: Hiroki Sato In-Reply-To: <201201200138.q0K1cSou016739@svn.freebsd.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.3.51 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Fri_Jan_20_12_32_56_2012_697)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [IPv6:2001:2f0:104:e001::32]); Fri, 20 Jan 2012 12:36:30 +0900 (JST) X-Spam-Status: No, score=-104.6 required=13.0 tests=BAYES_00, CONTENT_TYPE_PRESENT, RDNS_NONE, SPF_SOFTFAIL, USER_IN_WHITELIST autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 03:36:34 -0000 ----Security_Multipart(Fri_Jan_20_12_32_56_2012_697)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Eitan Adler wrote in <201201200138.q0K1cSou016739@svn.freebsd.org>: ea> Author: eadler ea> Date: Fri Jan 20 01:38:28 2012 ea> New Revision: 230354 ea> URL: http://svn.freebsd.org/changeset/base/230354 ea> ea> Log: ea> Fix a variety of warnings when compiling with gcc46 ea> ea> Approved by: dim, cperciva (mentor, blanket for pre-mentorship already-approved commits) ea> MFC after: 3 days ea> ea> Modified: ea> head/usr.sbin/makefs/cd9660.c Removing the dot handling part and leaving a comment in lines 1106-1117 make people confused. In addition to that, I personally don't think this should be removed because our cd9660.c is still based on NetBSD's one in any way---bugfixes on our side have been reported to the upstream and we will import useful changes from there if any. Although the current dot handling is useless, keeping the difference between the two small still has a meaning. -- Hiroki ----Security_Multipart(Fri_Jan_20_12_32_56_2012_697)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk8Y4GgACgkQTyzT2CeTzy17TwCeNf8nCaYUTJ7ouN2v4wkXuJTb P88An3ZRYyFsDUmkRgNXUm74QwB7CN5i =D+Nd -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Jan_20_12_32_56_2012_697)----