Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Jan 2015 03:31:46 +0300
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Cc:        Craig Rodrigues <rodrigc@FreeBSD.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, Nikos Vassiliadis <nvass@gmx.com>, src-committers@freebsd.org
Subject:   Re: svn commit: r276747 - head/sys/netpfil/pf
Message-ID:  <20150108003146.GL15484@FreeBSD.org>
In-Reply-To: <AEFC5AEF-7700-426A-96D3-A14BF68CA9BC@lists.zabbadoz.net>
References:  <201501060903.t06934qp081875@svn.freebsd.org> <20150107204631.GG15484@FreeBSD.org> <AEFC5AEF-7700-426A-96D3-A14BF68CA9BC@lists.zabbadoz.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 08, 2015 at 12:21:57AM +0000, Bjoern A. Zeeb wrote:
B> 
B> > On 07 Jan 2015, at 20:46 , Gleb Smirnoff <glebius@freebsd.org> wrote:
B> > 
B> > On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote:
B> > C> Author: rodrigc
B> > C> Date: Tue Jan  6 09:03:03 2015
B> > C> New Revision: 276747
B> > C> URL: https://svnweb.freebsd.org/changeset/base/276747
B> > C> 
B> > C> Log:
B> > C>   Instead of creating a purge thread for every vnet, create
B> > C>   a single purge thread and clean up all vnets from this thread.
B> > C>   
B> > C>   PR:                     194515
B> > C>   Differential Revision:  D1315
B> > C>   Submitted by:           Nikos Vassiliadis <nvass@gmx.com>
B> > 
B> > I am not sure that this is a good idea. The core idea of VNETs
B> > is that they are isolated from each other. If we serialize purging,
B> > then vnets are strongly affecting each other.
B> > 
B> > AFAIU, from the PR there is some panic fixed. What is the actual bug
B> > and why couldn't it be fixed with having per-vnet thread?
B> 
B> You don’t 30000 whatever pf purging threads on a system all running, possibly competing for some resources, e.g., locks?

Isn't a vnet, which is a jail, already a set of a dozen of processes? So,
if you are speaking of "30000 whatever pf purging threads", then you
already mean "1 mln whatever processes".

Speaking of pf purging threads competing for resources. If someone wants
really independent pfs in vnets, then locks should be virtualized as well.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150108003146.GL15484>