From owner-cvs-all@FreeBSD.ORG Fri Feb 16 10:04:20 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9B09516A402; Fri, 16 Feb 2007 10:04:20 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 625E813C4B3; Fri, 16 Feb 2007 10:04:20 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 02BE2485B8; Fri, 16 Feb 2007 05:04:20 -0500 (EST) Date: Fri, 16 Feb 2007 10:04:19 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Pawel Jakub Dawidek In-Reply-To: <20070216085810.GB55867@garage.freebsd.pl> Message-ID: <20070216100310.J83539@fledge.watson.org> References: <200702152208.l1FM8aY7002188@repoman.freebsd.org> <20070216073206.C83539@fledge.watson.org> <20070216085810.GB55867@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vfsops.c hpfs_vnops.c src/sys/fs/msdosfs msdosfs_vfsops.c msdosfs_vnops.c src/sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c src/sys/fs/nullfs null_vfsops.c null_vnops.c src/sys/fs/udf udf.h udf_vfsops.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2007 10:04:20 -0000 On Fri, 16 Feb 2007, Pawel Jakub Dawidek wrote: > On Fri, Feb 16, 2007 at 07:33:12AM +0000, Robert Watson wrote: >> >> On Thu, 15 Feb 2007, Pawel Jakub Dawidek wrote: >> >>> Move vnode-to-file-handle translation from vfs_vptofh to vop_vptofh method. >>> This way we may support multiple structures in v_data vnode field within >>> one file system without using black magic. >>> >>> Vnode-to-file-handle should be VOP in the first place, but was made VFS >>> operation to keep interface as compatible as possible with SUN's VFS. >>> BTW. Now Solaris also implements vnode-to-file-handle as VOP operation. >>> >>> VFS_VPTOFH() was left for API backward compatibility, but is marked for >>> removal before 8.0-RELEASE. >>> >>> Approved by: mckusick >>> Discussed with: many (on IRC) >>> Tested with: ufs, msdosfs, cd9660, nullfs and zfs >> >> Do you think API backward compatibility is actually required in 7.x? It >> looks like you've updated all the file systems, in which case the >> temptation would be to drop it as we already have other VFS changes in 7.x >> from 6.x. > > Those changes break API or only ABI? My change break ABI backward > compatibility, but I thought it will be good to leave API compatibility so > 3rd party file systems (eg. from ports) have time to catch-up. If this is > not necessary, I'll remove it right away. I'd rather we forced the breakage sooner, as ports may not get fixed if they don't get broken. :-) Doing it now maximizes the amount of time for these changes to settle, and mean that new work will be done to the new APIs. If there were MFC plans for this, then having compatibility APIs in the MFC is important, of course. Robert N M Watson Computer Laboratory University of Cambridge