From owner-cvs-all Sat Jul 21 17:50:59 2001 Delivered-To: cvs-all@freebsd.org Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [62.232.68.68]) by hub.freebsd.org (Postfix) with ESMTP id 7878C37B403; Sat, 21 Jul 2001 17:50:48 -0700 (PDT) (envelope-from paul@freebsd-services.co.uk) Received: from lobster.originative.co.uk (lobster [62.232.68.81]) by mailgate.originative.co.uk (Postfix) with ESMTP id 408741D149; Sun, 22 Jul 2001 01:50:35 +0100 (BST) Date: Sun, 22 Jul 2001 01:50:34 +0100 From: Paul Richards To: Bruce Evans , Ruslan Ermilov Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <517230000.995763034@lobster.originative.co.uk> In-Reply-To: X-Mailer: Mulberry/2.0.8 (Linux/x86 Demo) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --On Saturday, July 21, 2001 01:38:06 +1000 Bruce Evans wrote: > On Fri, 20 Jul 2001, Ruslan Ermilov wrote: > >> On Fri, Jul 20, 2001 at 09:35:41PM +1000, Bruce Evans wrote: >> [...] >> > Anyway, the continuation indent rule is at the lexical level, so it >> > doesn't apply to `else if'. >> > >> Doh, and why I have removed that final `else' part? :-) >> >> What I was talking about was: >> if (mylevel == SLC_DEFAULT) { >> slctab[(int)func].current.flag = flag; >> slctab[(int)func].current.val = val; >> flag |= SLC_ACK; >> } else if (hislevel == SLC_CANTCHANGE && >> mylevel == SLC_CANTCHANGE) { Why is this good style? I find that much harder to read than the case where the tests are lined up i.e. } else if (hislevel == SLC_CANTCHANGE && mylevel == SLC_CANTCHANGE) { Paul. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message