Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Nov 2015 00:12:32 +0100
From:      Hans Petter Selasky <hps@selasky.org>
To:        Randall Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r290805 - in head: share/man/man9 sys/kern sys/net sys/netinet sys/netinet6 sys/netpfil/pf
Message-ID:  <56466E60.7000304@selasky.org>
In-Reply-To: <201511132251.tADMpa8o053824@repo.freebsd.org>
References:  <201511132251.tADMpa8o053824@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/13/15 23:51, Randall Stewart wrote:
> Modified: head/sys/kern/subr_taskqueue.c
> ==============================================================================
> --- head/sys/kern/subr_taskqueue.c	Fri Nov 13 22:33:51 2015	(r290804)
> +++ head/sys/kern/subr_taskqueue.c	Fri Nov 13 22:51:35 2015	(r290805)
> @@ -496,7 +496,7 @@ taskqueue_cancel_timeout(struct taskqueu
>   	int error;
>
>   	TQ_LOCK(queue);
> -	pending = !!callout_stop(&timeout_task->c);
> +	pending = !!(callout_stop(&timeout_task->c) > 0);
>   	error = taskqueue_cancel_locked(queue, &timeout_task->t, &pending1);

The "!!" can go away after the "> 0" which is already boolean.

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56466E60.7000304>