From nobody Thu Oct 7 21:20:48 2021 X-Original-To: dev-commits-doc-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 97D9C12BF518 for ; Thu, 7 Oct 2021 21:20:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HQPPZ3s7fz563j; Thu, 7 Oct 2021 21:20:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 14D872C48E; Thu, 7 Oct 2021 21:20:49 +0000 (UTC) (envelope-from jhb@FreeBSD.org) To: "Danilo G. Baio" Cc: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org References: <202110062359.196NxFqS079143@gitrepo.freebsd.org> <0595c299-55ed-17c4-74ac-16a804541473@FreeBSD.org> <20211007205425.j4idybl7jrtwxeal@t480.local> From: John Baldwin Subject: Re: git: 5a5db32f4a - main - Fix build after c8e8be58e580 Message-ID: Date: Thu, 7 Oct 2021 14:20:48 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Commit messages for all branches of the doc repository List-Archive: https://lists.freebsd.org/archives/dev-commits-doc-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-doc-all@freebsd.org X-BeenThere: dev-commits-doc-all@freebsd.org MIME-Version: 1.0 In-Reply-To: <20211007205425.j4idybl7jrtwxeal@t480.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 10/7/21 1:54 PM, Danilo G. Baio wrote: > On Thu, Oct 07, 2021 at 09:22:56AM -0700, John Baldwin wrote: >> On 10/6/21 4:59 PM, Danilo G. Baio wrote: >>> The branch main has been updated by dbaio: >>> >>> URL: https://cgit.FreeBSD.org/doc/commit/?id=5a5db32f4a1e3f507cdc55f92d53e63adbb4f022 >>> >>> commit 5a5db32f4a1e3f507cdc55f92d53e63adbb4f022 >>> Author: Danilo G. Baio >>> AuthorDate: 2021-10-06 23:57:27 +0000 >>> Commit: Danilo G. Baio >>> CommitDate: 2021-10-06 23:57:27 +0000 >>> >>> Fix build after c8e8be58e580 >> >> It used to be possible to use 'make' in individual books or articles to test >> things, and also to only build just html versions and not be required to >> build PDF. Apparently our new system doesn't permit either of those, so I >> gave up on trying to test this pre-commit. >> >> -- >> John Baldwin > > > To speed up the build time (right now), you can build only English HTML > documentation this way: > > $ cd documentation > $ DOC_LANG="en" make > > 14 seconds here > against 2 minutes for all languages. > > The `make run` also helps as pointed by Sergio. > > > ps. PDF is not built automatically. I tried plain 'make' at the documentation top-level and it failed due to missing asciidoctor-pdf (I had built docproj with PDF unchecked). I have used 'make' just fine for the website in the past. The error message came from the 'requirements' target in documentation/Makefile: RUN_DEPENDS= ${PYTHON_CMD} \ ${HUGO_CMD} \ ${LOCALBASE}/bin/asciidoctor \ ${LOCALBASE}/bin/asciidoctor-pdf \ ${LOCALBASE}/bin/rougify ... all: requirements starting-message generate-books-toc generate-pgpkeys-txt build run: requirements starting-message generate-books-toc generate-pgpkeys-txt run-local ... requirements: .for dep in ${RUN_DEPENDS} .if !exists(${dep}) @(echo ${dep} not found, please run 'pkg install docproj python3'; exit 1) .endif .endfor Thus, even using 'make html' or 'make run' will fail if the PDF tools aren't installed even though those make targets don't generate PDF. The problem for me wasn't the build time, it was the explicit error and exit above. -- John Baldwin