From owner-cvs-all Sun Jan 14 15:22:38 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 4520D37B400; Sun, 14 Jan 2001 15:22:12 -0800 (PST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id DB4876ABFB; Mon, 15 Jan 2001 09:52:09 +1030 (CST) Date: Mon, 15 Jan 2001 09:52:09 +1030 From: Greg Lehey To: Doug Barton Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinumlock.c vinumvar.h Message-ID: <20010115095209.L28496@wantadilla.lemis.com> References: <200101140634.f0E6Ywc16968@freefall.freebsd.org> <3A61766D.80E7349C@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3A61766D.80E7349C@FreeBSD.org>; from DougB@FreeBSD.org on Sun, Jan 14, 2001 at 01:50:37AM -0800 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sunday, 14 January 2001 at 1:50:37 -0800, Doug Barton wrote: > Greg Lehey wrote: >> >> grog 2001/01/13 22:34:58 PST >> >> Modified files: >> sys/dev/vinum vinumlock.c vinumvar.h >> Log: >> struct rangelock: Remove the field 'plex' from the entry. Range locks >> are accessed only via the plex, so there's never any confusion as to >> the plex number. This value was, as a result, unused. >> >> Revision Changes Path >> 1.21 +2 -5 src/sys/dev/vinum/vinumlock.c >> 1.36 +1 -2 src/sys/dev/vinum/vinumvar.h >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/vinum/vinumlock.c.diff?&r1=1.20&r2=1.21&f=h >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/vinum/vinumvar.h.diff?&r1=1.35&r2=1.36&f=h > > Seems to be a world breaker: > > cc -O -pipe -I/usr/src/sbin/vinum/../../sys -Wall -DVINUMDEBUG -c > /usr/src/sbin/vinum/list.c > /usr/src/sbin/vinum/list.c: In function `vinum_info': > /usr/src/sbin/vinum/list.c:1005: structure has no member named `plexno' > /usr/src/sbin/vinum/list.c:1013: structure has no member named `plexno' > /usr/src/sbin/vinum/list.c:1021: structure has no member named `plexno' > *** Error code 1 > > Stop in /usr/src/sbin/vinum. Pass me the pointy hat. I committed the fix last night just before going to bed. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message