Date: Mon, 18 Sep 1995 16:28:56 -0700 From: David Greenman <davidg@Root.COM> To: Terry Lambert <terry@lambert.org> Cc: julian@freefall.freebsd.org (Julian Elischer), hackers@freefall.freebsd.org Subject: Re: why is this not a bug in namei? Message-ID: <199509182328.QAA03738@corbin.Root.COM> In-Reply-To: Your message of "Mon, 18 Sep 95 13:57:49 PDT." <199509182057.NAA08583@phaeton.artisoft.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>The patches happen to modify vfs_syscalls.c for single entry/exit for all >functions at the same time, something that was required for buffer >allocation bookkeeping and wants to be done for kernel multithreading and >SMP kernel reentrancy in any case. There are some cases where a single entry point is useful, but I personally hate the spaghetti of goto's that I've seen with your code. It goes a long way toward obscuring the code flow and makes it difficult to read. It's especially bad when you have 3 or more exit labels. I fail to see the requirement for any of this in an SMP kernel, and the need for this to have "buffer allocation bookeeping" is dubious. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509182328.QAA03738>