From owner-freebsd-hackers  Mon Sep 18 16:28:01 1995
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id QAA09060
          for hackers-outgoing; Mon, 18 Sep 1995 16:28:01 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.17])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id QAA09051
          ; Mon, 18 Sep 1995 16:27:59 -0700
Received: from corbin.Root.COM (corbin [198.145.90.34]) by Root.COM (8.6.12/8.6.5) with ESMTP id QAA19043; Mon, 18 Sep 1995 16:26:36 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id QAA03738; Mon, 18 Sep 1995 16:28:56 -0700
Message-Id: <199509182328.QAA03738@corbin.Root.COM>
To: Terry Lambert <terry@lambert.org>
cc: julian@freefall.freebsd.org (Julian Elischer),
        hackers@freefall.freebsd.org
Subject: Re: why is this not a bug in namei? 
In-reply-to: Your message of "Mon, 18 Sep 95 13:57:49 PDT."
             <199509182057.NAA08583@phaeton.artisoft.com> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Mon, 18 Sep 1995 16:28:56 -0700
Sender: owner-hackers@FreeBSD.org
Precedence: bulk

>The patches happen to modify vfs_syscalls.c for single entry/exit for all
>functions at the same time, something that was required for buffer
>allocation bookkeeping and wants to be done for kernel multithreading and
>SMP kernel reentrancy in any case.

   There are some cases where a single entry point is useful, but I personally
hate the spaghetti of goto's that I've seen with your code. It goes a long way
toward obscuring the code flow and makes it difficult to read. It's especially
bad when you have 3 or more exit labels. I fail to see the requirement for any
of this in an SMP kernel, and the need for this to have "buffer allocation
bookeeping" is dubious.

-DG