From owner-svn-src-all@FreeBSD.ORG Sat Feb 15 18:03:42 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 31DC7C7E; Sat, 15 Feb 2014 18:03:42 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DCD841BC8; Sat, 15 Feb 2014 18:03:41 +0000 (UTC) Received: from [192.168.1.108] (047-109-045-062.dynamic.caiway.nl [62.45.109.47]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D79BB5C45; Sat, 15 Feb 2014 19:03:30 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_6FA9FA4F-CBC9-4595-8457-F3F0DDF37480"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r261916 - head/sys/dev/xen/console From: Dimitry Andric In-Reply-To: <20140216035823.I2978@besplex.bde.org> Date: Sat, 15 Feb 2014 19:03:24 +0100 Message-Id: <3D4CA3E5-3B69-4D46-953D-A2C8B051DDFB@FreeBSD.org> References: <201402151237.s1FCbRnh000507@svn.freebsd.org> <20140216035823.I2978@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.1827) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Feb 2014 18:03:42 -0000 --Apple-Mail=_6FA9FA4F-CBC9-4595-8457-F3F0DDF37480 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 15 Feb 2014, at 18:02, Bruce Evans wrote: > On Sat, 15 Feb 2014, Dimitry Andric wrote: ... > Why? There are hundreds if not thousands of static inline functions in > headers, and most of these functions are not always used, so there would > be [hundreds if not thousands] * [number of #includes] compiler warnings > if compilers warned about things like this. They could handle include > files specially, but shouldn't. Some compilers (e.g. clang 3.4) do warn about this. :-) If code is unused, it should be cleaned up, IMHO. But because I got several remarks in the past that deleting code might sometimes inconvenience developers, I prefer to just use #if 0 instead. For some contributed sources, or sources which have no maintainer or an unresponsive maintainer, I usually just disable the warning instead. But that won't clean up the dead code... -Dimitry --Apple-Mail=_6FA9FA4F-CBC9-4595-8457-F3F0DDF37480 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlL/q/AACgkQsF6jCi4glqOIkgCgxDkTJ53YtGGvVZ27/hzA3bnd BQ0AoO7dIPwGIZ7MWAA/V9eZx9VEztTh =ujzm -----END PGP SIGNATURE----- --Apple-Mail=_6FA9FA4F-CBC9-4595-8457-F3F0DDF37480--