Date: Sat, 15 Feb 2014 19:03:24 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r261916 - head/sys/dev/xen/console Message-ID: <3D4CA3E5-3B69-4D46-953D-A2C8B051DDFB@FreeBSD.org> In-Reply-To: <20140216035823.I2978@besplex.bde.org> References: <201402151237.s1FCbRnh000507@svn.freebsd.org> <20140216035823.I2978@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_6FA9FA4F-CBC9-4595-8457-F3F0DDF37480 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 15 Feb 2014, at 18:02, Bruce Evans <brde@optusnet.com.au> wrote: > On Sat, 15 Feb 2014, Dimitry Andric wrote: ... > Why? There are hundreds if not thousands of static inline functions in > headers, and most of these functions are not always used, so there would > be [hundreds if not thousands] * [number of #includes] compiler warnings > if compilers warned about things like this. They could handle include > files specially, but shouldn't. Some compilers (e.g. clang 3.4) do warn about this. :-) If code is unused, it should be cleaned up, IMHO. But because I got several remarks in the past that deleting code might sometimes inconvenience developers, I prefer to just use #if 0 instead. For some contributed sources, or sources which have no maintainer or an unresponsive maintainer, I usually just disable the warning instead. But that won't clean up the dead code... -Dimitry --Apple-Mail=_6FA9FA4F-CBC9-4595-8457-F3F0DDF37480 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlL/q/AACgkQsF6jCi4glqOIkgCgxDkTJ53YtGGvVZ27/hzA3bnd BQ0AoO7dIPwGIZ7MWAA/V9eZx9VEztTh =ujzm -----END PGP SIGNATURE----- --Apple-Mail=_6FA9FA4F-CBC9-4595-8457-F3F0DDF37480--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D4CA3E5-3B69-4D46-953D-A2C8B051DDFB>