Date: Sat, 04 Nov 2023 16:27:39 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 273753] [exp-run] Against llvm-17-update branch on GitHub Message-ID: <bug-273753-7788-BGiaoeXfjS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-273753-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-273753-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273753 --- Comment #57 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dbfcd2a9b6f168c590da52dfefa0aacf= 1b021d30f commit bfcd2a9b6f168c590da52dfefa0aacf1b021d30f Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2023-10-26 10:45:00 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2023-11-04 16:26:51 +0000 www/qt5-webengine: fix build with libc++ 17 Building www/qt5-webengine with libc++ 17 results in the following compile errors: In file included from ../../../../kde-qtwebengine-5.15.15p0/src/3rdparty/chromium/third_party/per= fetto/src/trace_processor/trace_sorter.cc:17: In file included from /usr/include/c++/v1/algorithm:1803: In file included from /usr/include/c++/v1/__algorithm/nth_element.h:1= 5: /usr/include/c++/v1/__algorithm/sort.h:577:14: error: no viable overloaded '=3D' 577 | *__begin =3D _Ops::__iter_move(__pivot_pos); | ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/v1/__algorithm/sort.h:802:20: note: in instantiation= of function template specialization 'std::__bitset_partition<std::_ClassicAlgPolicy, perfetto::base::CircularQueue<perfetto::trace_processor::TimestampedTracePi= ece>::Iterator, std::__less<void, void> &>' requested here 802 | ? std::__bitset_partition<_AlgPolicy, _RandomAccessIterator, _Compare>(__first, __last, __comp) | ^ /usr/include/c++/v1/__algorithm/sort.h:878:8: note: in instantiation = of function template specialization 'std::__introsort<std::_ClassicAlgPolicy, std::__less<void, void> &, perfetto::base::CircularQueue<perfetto::trace_processor::TimestampedTracePi= ece>::Iterator, false>' requested here 878 | std::__introsort<_AlgPolicy, | ^ /usr/include/c++/v1/__algorithm/sort.h:946:10: note: in instantiation= of function template specialization 'std::__sort_dispatch<std::_ClassicAlgPoli= cy, perfetto::base::CircularQueue<perfetto::trace_processor::TimestampedTracePi= ece>::Iterator, std::__less<void, void>>' requested here 946 | std::__sort_dispatch<_AlgPolicy>(std::__unwrap_iter(__fir= st), std::__unwrap_iter(__last), __comp); | ^ /usr/include/c++/v1/__algorithm/sort.h:954:8: note: in instantiation = of function template specialization 'std::__sort_impl<std::_ClassicAlgPolicy, perfetto::base::CircularQueue<perfetto::trace_processor::TimestampedTracePi= ece>::Iterator, std::__less<void, void>>' requested here 954 | std::__sort_impl<_ClassicAlgPolicy>(std::move(__first), std::move(__last), __comp); | ^ /usr/include/c++/v1/__algorithm/sort.h:960:8: note: in instantiation = of function template specialization 'std::sort<perfetto::base::CircularQueue<perfetto::trace_processor::Timesta= mpedTracePiece>::Iterator, std::__less<void, void>>' requested here 960 | std::sort(__first, __last, __less<>()); | ^ =20=20=20=20=20 ../../../../kde-qtwebengine-5.15.15p0/src/3rdparty/chromium/third_party/per= fetto/src/trace_processor/trace_sorter.cc:51:8: note: in instantiation of function template specialization 'std::sort<perfetto::base::CircularQueue<perfetto::trace_processor::Timesta= mpedTracePiece>::Iterator>' requested here 51 | std::sort(sort_begin, events_.end()); | ^ =20=20=20=20=20 ../../../../kde-qtwebengine-5.15.15p0/src/3rdparty/chromium/third_party/per= fetto/src/trace_processor/timestamped_trace_piece.h:191:26: note: candidate function not viable: 'this' argument has type 'const perfetto::trace_processor::TimestampedTracePiece', but method is not marked const 191 | TimestampedTracePiece& operator=3D(TimestampedTracePiece&& = ttp) { | ^ =20=20=20=20=20 ../../../../kde-qtwebengine-5.15.15p0/src/3rdparty/chromium/third_party/per= fetto/src/trace_processor/timestamped_trace_piece.h:202:26: note: candidate function not viable: 'this' argument has type 'const perfetto::trace_processor::TimestampedTracePiece', but method is not marked const 202 | TimestampedTracePiece& operator=3D(const TimestampedTracePi= ece&) =3D delete; | ^ This is because perfetto's CircularQueue template is only half const-correct. Upstream fixed this in: =20=20=20 https://github.com/google/perfetto/commit/b82a213bcf71dd8e68b53941375936c79= 05c0ff2 so apply that fix to qt5-webengine's older copy of perfetto. PR: 274740, 273753 MFH: 2023Q4 ...clude_perfetto_ext_base_circular__queue.h (new) | 35 ++++++++++++++++++= ++++ 1 file changed, 35 insertions(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-273753-7788-BGiaoeXfjS>