From owner-svn-src-all@freebsd.org Wed Sep 9 23:05:49 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C53C3DFBDC; Wed, 9 Sep 2020 23:05:49 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BmyL51msrz44Cp; Wed, 9 Sep 2020 23:05:49 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 209BD91C3; Wed, 9 Sep 2020 23:05:49 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 089N5nOj046080; Wed, 9 Sep 2020 23:05:49 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 089N5lB3046072; Wed, 9 Sep 2020 23:05:47 GMT (envelope-from imp@FreeBSD.org) Message-Id: <202009092305.089N5lB3046072@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Wed, 9 Sep 2020 23:05:47 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r365543 - in stable/12/sys/dev: an wi X-SVN-Group: stable-12 X-SVN-Commit-Author: imp X-SVN-Commit-Paths: in stable/12/sys/dev: an wi X-SVN-Commit-Revision: 365543 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2020 23:05:49 -0000 Author: imp Date: Wed Sep 9 23:05:47 2020 New Revision: 365543 URL: https://svnweb.freebsd.org/changeset/base/365543 Log: MFC r365015: r365015 | imp | 2020-08-31 17:31:16 -0600 (Mon, 31 Aug 2020) | 12 lines Warn for the non pccard attachments These devices have non-pccard attachments. Warn for those as well. Both an and wi don't do the modern cyrpto needed to use these cards on secure wifi networks. an needs firmware from Cisco, which I don't think was ever produced. wi could in theory do it with raw frames and on-host encryption, but nobody has written that in the 15 years since WEP was cracked. MFC After: 3 days Noticed by: rgrimes Differential Revision: https://reviews.freebsd.org/D26138 Modified: stable/12/sys/dev/an/if_an_isa.c stable/12/sys/dev/an/if_an_pccard.c stable/12/sys/dev/an/if_an_pci.c stable/12/sys/dev/wi/if_wi_macio.c stable/12/sys/dev/wi/if_wi_pccard.c stable/12/sys/dev/wi/if_wi_pci.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/an/if_an_isa.c ============================================================================== --- stable/12/sys/dev/an/if_an_isa.c Wed Sep 9 23:04:40 2020 (r365542) +++ stable/12/sys/dev/an/if_an_isa.c Wed Sep 9 23:05:47 2020 (r365543) @@ -127,6 +127,7 @@ an_attach_isa(device_t dev) an_release_resources(dev); return (error); } + gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto"); return (0); } Modified: stable/12/sys/dev/an/if_an_pccard.c ============================================================================== --- stable/12/sys/dev/an/if_an_pccard.c Wed Sep 9 23:04:40 2020 (r365542) +++ stable/12/sys/dev/an/if_an_pccard.c Wed Sep 9 23:05:47 2020 (r365543) @@ -157,6 +157,6 @@ fail: if (error) an_release_resources(dev); else - gone_in_dev(dev, 13, "pccard removed"); + gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto"); return (error); } Modified: stable/12/sys/dev/an/if_an_pci.c ============================================================================== --- stable/12/sys/dev/an/if_an_pci.c Wed Sep 9 23:04:40 2020 (r365542) +++ stable/12/sys/dev/an/if_an_pci.c Wed Sep 9 23:05:47 2020 (r365543) @@ -230,7 +230,8 @@ an_attach_pci(dev) NULL, an_intr, sc, &sc->irq_handle); if (error) device_printf(dev, "couldn't setup interrupt\n"); - + else + gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto"); fail: if (error) an_release_resources(dev); Modified: stable/12/sys/dev/wi/if_wi_macio.c ============================================================================== --- stable/12/sys/dev/wi/if_wi_macio.c Wed Sep 9 23:04:40 2020 (r365542) +++ stable/12/sys/dev/wi/if_wi_macio.c Wed Sep 9 23:05:47 2020 (r365543) @@ -142,6 +142,8 @@ wi_macio_attach(device_t dev) error = wi_attach(dev); if (error != 0) wi_free(dev); + else + gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto"); } return error; } Modified: stable/12/sys/dev/wi/if_wi_pccard.c ============================================================================== --- stable/12/sys/dev/wi/if_wi_pccard.c Wed Sep 9 23:04:40 2020 (r365542) +++ stable/12/sys/dev/wi/if_wi_pccard.c Wed Sep 9 23:05:47 2020 (r365543) @@ -200,7 +200,7 @@ wi_pccard_attach(device_t dev) error = wi_attach(dev); if (error != 0) wi_free(dev); - gone_in_dev(dev, 13, "pccard removed"); + gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto"); } return error; } Modified: stable/12/sys/dev/wi/if_wi_pci.c ============================================================================== --- stable/12/sys/dev/wi/if_wi_pci.c Wed Sep 9 23:04:40 2020 (r365542) +++ stable/12/sys/dev/wi/if_wi_pci.c Wed Sep 9 23:05:47 2020 (r365543) @@ -233,6 +233,8 @@ wi_pci_attach(device_t dev) error = wi_attach(dev); if (error != 0) wi_free(dev); + else + gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto"); return (error); }