From owner-dev-commits-src-all@freebsd.org Sun Dec 27 19:22:28 2020 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B7A444C46AB; Sun, 27 Dec 2020 19:22:28 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D3rD44dNhz3HYt; Sun, 27 Dec 2020 19:22:28 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x329.google.com with SMTP id c124so7764200wma.5; Sun, 27 Dec 2020 11:22:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iSV9qwRH9lNpNNo6KTbg9tuC22ySn0FwA1SWu7iovNQ=; b=AYju1pIvFEy+01Ouyl5CRaTFGFVaYZnonBgA8sYBv9lVN1iNfFHXghlWEDN0IFHqwR Q4GrOmnYxBmHsGlE+d/YjlgyZaJhLFfWwPj4OBr748kwGo195xEQyQDutmKqESU+PXm3 8xsNBzdqpMlUQFJJ6xmWkmLbBxGAQ8lKN22myh+vmWJqN83TeflewHA61lPMbVrdUL5A 4cqsHKp1MhXk+bP1SeAWdFZVKiZKOVcEoqK5Jb1zelxbe5CluaHrZT/cSttpTcVY9uOf qDJ6danVAh8KtxOKDZ/mWE6JR9x6fM/d91s3+CpQ8gRBe7i9I8/2WLumoEeAI+BjWiAy A/9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iSV9qwRH9lNpNNo6KTbg9tuC22ySn0FwA1SWu7iovNQ=; b=LFqylyKQWVI+XjXofMRHMyxqwK5IS2wxOd0LDHE7dSagIZ5j5Ng9w6Dr+Cpin+sV7/ 7tVRSbRa3UBtvoBGcjyf5t8YgAQxJAqNHXNPqfVWR9sKwmc1lyCle1ifsrNK/U2NF3a+ pUMCadojQAmNa0v9quGYXS4qw3aFKFGTZCfT7zJLswJWuqHn1lMZ14SBgPc+HprrD9T/ Njh7oCjXSI8313X4mQQyK0Xoornb5Cigie67+7LDLgK0PAzc2K5kbfuckO7zHc3/Zb1Z zuIHwj68EthNGMv9HxpNSNmVOrmoLNqRih8zzzHv8XiyqDBEvKiouxaSbVpjjzllEwIs pA5w== X-Gm-Message-State: AOAM530To93ITDrQ64IVy/2PPKBCsmydiPyYlj5QqNsIVHg9JIOX7Ku+ /BrH55C2XyAj9jOVZw7fvbg706Tk6Xld08y97F4LArrIAOo= X-Google-Smtp-Source: ABdhPJzzITJDle4m1Xyk/MeqACd1564f+SnYzjrDBjtOlMoEC5YgTgcXY85HrrKBh6xjC9FZfbH0QgauYRCQUf371Hg= X-Received: by 2002:a7b:c773:: with SMTP id x19mr16928173wmk.127.1609096946423; Sun, 27 Dec 2020 11:22:26 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:f811:0:0:0:0:0 with HTTP; Sun, 27 Dec 2020 11:22:25 -0800 (PST) In-Reply-To: References: <202012271904.0BRJ4DWF044873@gitrepo.freebsd.org> From: Mateusz Guzik Date: Sun, 27 Dec 2020 20:22:25 +0100 Message-ID: Subject: Re: git: a1fc1f10c65f - main - Revert "cache: modification and last entry filling support in lockless lookup" To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D3rD44dNhz3HYt X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Dec 2020 19:22:28 -0000 I ran into it myself building one of the affected ports (devel/gettext-runtime). On 12/27/20, Mark Johnston wrote: > On Sun, Dec 27, 2020 at 07:04:13PM +0000, Mateusz Guzik wrote: >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=a1fc1f10c65fe8684d09d2252c19ebb213182b4f >> >> commit a1fc1f10c65fe8684d09d2252c19ebb213182b4f >> Author: Mateusz Guzik >> AuthorDate: 2020-12-27 19:02:29 +0000 >> Commit: Mateusz Guzik >> CommitDate: 2020-12-27 19:02:29 +0000 >> >> Revert "cache: modification and last entry filling support in lockless >> lookup" >> >> This reverts commit 6dbb07ed6872ae7988b9b705e322c94658eba6d1. >> >> Some ports unreliably fail to build with rmdir getting ENOTEMPTY. > > I also got this when running the fs/tmpfs/rename_test:dots test > > panic: Assertion (cnp->cn_flags & ISDOTDOT) != 0 failed at > /usr/home/markj/src/freebsd-dev/sys/kern/vfs_cache.c:1663 > cpuid = 22 > time = 1609095767 > KDB: stack backtrace: > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe01aeb764b0 > vpanic() at vpanic+0x181/frame 0xfffffe01aeb76500 > panic() at panic+0x43/frame 0xfffffe01aeb76560 > cache_lookup_dotdot() at cache_lookup_dotdot+0x509/frame 0xfffffe01aeb765d0 > vfs_cache_lookup() at vfs_cache_lookup+0x7b/frame 0xfffffe01aeb76620 > cache_fplookup_final_modifying() at > cache_fplookup_final_modifying+0x1b5/frame 0xfffffe01aeb766a0 > cache_fplookup() at cache_fplookup+0x8f2/frame 0xfffffe01aeb767b0 > namei() at namei+0x17f/frame 0xfffffe01aeb76870 > kern_renameat() at kern_renameat+0x10c/frame 0xfffffe01aeb76ac0 > amd64_syscall() at amd64_syscall+0x12e/frame 0xfffffe01aeb76bf0 > fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe01aeb76bf0 > -- Mateusz Guzik