From nobody Mon Dec 18 22:45:56 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SvFKc4Zk8z54CRd; Mon, 18 Dec 2023 22:45:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SvFKc493qz3ZRL; Mon, 18 Dec 2023 22:45:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702939556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QZvhSw1XQ8VzX+ZuW2QKo8ddr6NiasNjnbnPnp4VvDk=; b=OsQ5xtodOxWP94WWFUL3VvoF8VTgSZGu++GXA0y5xGlbWAsBInJ7C3SfuCkJ5AMk5PEkmu PMDwVQ5q5N/r6NugkJeYBWsJffn9od3aRNLY8DFhrnP5zEhUj84mDM7iQ4YyDjfcRMJYZn ARlZ8LwLnCTVrs59Si73OtQ/jHdRqMEJc/0a+96GnE/hk2Ft59pRBytWVONLXzb7jL98R7 SBfJL1ZZGwUTApnnWSGeOUIqg/7srL1UvxQEr0scVIhdD86/iW+VC6TD3A9stYEB+lEoX+ lgsdvCT8DonZXf158azh+xcfqhdhpuzgefculipwiR+MTOID3SnqRBUW8eWQyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1702939556; a=rsa-sha256; cv=none; b=YQBCLUDmvq/4yuHk0yFF1fLW5Xy0w1jgYv/b6xbYPvt/VVCnC/QOgT1Q6n5o753tKdSLD2 hIhw7WgecY5LuIxDzHYrUIpqGgrl9qL4qfTAbJdHiVe+p6Kl/VCNhS9Hd+AE6J3ImJXVj/ aHE+wMsQvNhgTkjedO1a4kqCvNM6PX+efZ5hJKfe+haQ/hJOHA0I7S7Nz6XNICDJQWYZon yf6c6ZiGh+Q406gDMV2w4e1TxRaIuKb1+kkvxNj1iQf9JRiAknuxQZldP9E6XCBtWjReRj b5PCpcI5ICpZ9uRu9WgCEN0utzKRsDGtQQ1JXVLz5FJzVG5f55UqU+St6KCpqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702939556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QZvhSw1XQ8VzX+ZuW2QKo8ddr6NiasNjnbnPnp4VvDk=; b=TPiepOigrINt2p3VMlzEJATG+k4yZhpOqT3mUQJmPXJer0gTHpvJbzai98Od8Qlty4Zq1j xiwTbIEbWyaqNYO9tT3NniHfd9CGx6ChpiaVtdPOMJsPfy3A9DaVe0ZY4MGgjy+sn5iV+V zMvE6aioXm82/27Ls4zGyLxDrjKFqnjs1+nmNiMTEQUxHyvKJoCyT6B9Pb+38ZsQ7rKw4I 5NWeDy3n+CouTcDx9NMEEsZcMgfqSS9cD1fTvBYLSD+yfrBG0LnJb3IDly6nHvc+q9bWHt RXnhsd4S4skkOQG55iCTaC2AHKC23CvgeSEAc2X4m/bgMnNvSOClYkCiuhufvA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SvFKc3CfTzg0G; Mon, 18 Dec 2023 22:45:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3BIMjuxS040505; Mon, 18 Dec 2023 22:45:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3BIMjuFt040502; Mon, 18 Dec 2023 22:45:56 GMT (envelope-from git) Date: Mon, 18 Dec 2023 22:45:56 GMT Message-Id: <202312182245.3BIMjuFt040502@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: d9b7301bb791 - main - nvme: Initialize HMB entries before loading them into the controller List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d9b7301bb791faab48b6c7733c34078427b9a374 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d9b7301bb791faab48b6c7733c34078427b9a374 commit d9b7301bb791faab48b6c7733c34078427b9a374 Author: Mark Johnston AuthorDate: 2023-12-18 22:45:24 +0000 Commit: Mark Johnston CommitDate: 2023-12-18 22:45:24 +0000 nvme: Initialize HMB entries before loading them into the controller struct nvme_hmb_desc contains a pad field which was not getting initialized before being synced. This doesn't have much consequence but triggers a report from KMSAN, which verifies that host-filled DMA memory is initialized before it is made visible to the device. So, let's just initialize it properly. Reported by: KMSAN Reviewed by: mav, imp MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: Juniper Networks, Inc. Differential Revision: https://reviews.freebsd.org/D43090 --- sys/dev/nvme/nvme_ctrlr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index 836d13eaa16d..771e5cd1251b 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -1007,6 +1007,8 @@ again: } for (i = 0; i < ctrlr->hmb_nchunks; i++) { + memset(&ctrlr->hmb_desc_vaddr[i], 0, + sizeof(struct nvme_hmb_desc)); ctrlr->hmb_desc_vaddr[i].addr = htole64(ctrlr->hmb_chunks[i].hmbc_paddr); ctrlr->hmb_desc_vaddr[i].size = htole32(ctrlr->hmb_chunk / ctrlr->page_size);