From owner-freebsd-audit  Thu Jul  5 20:50:23 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP id 8FA6037B40E
	for <audit@FreeBSD.org>; Thu,  5 Jul 2001 20:50:21 -0700 (PDT)
	(envelope-from mike@coffee.q9media.com)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.2) id f66451H10795;
	Fri, 6 Jul 2001 00:05:01 -0400 (EDT)
	(envelope-from mike)
Date: Fri, 6 Jul 2001 00:05:01 -0400 (EDT)
Message-Id: <200107060405.f66451H10795@coffee.q9media.com>
To: Mike Heffner <mheffner@novacoxmail.com>
From: Mike Barcroft <mike@q9media.com>
Cc: audit@FreeBSD.org
Subject: Re: Teach tmpfile(3) about TMPDIR
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Mike Heffner <mheffner@novacoxmail.com> writes:
[...]
+       buf = malloc(tmpdirlen + (tmpdir[tmpdirlen - 1] == '/') ? 0 : 1 +
+           sizeof(TRAILER));
+       if (buf == NULL)
+               return NULL;
+       (void)sprintf(buf, "%s%s%s", tmpdir,
+           (tmpdir[tmpdirlen - 1] == '/') ? "" : "/", TRAILER);
[...]

Why not use asprintf(3) instead?  Like:
(void)asprintf(&buf, "%s%s%s", tmpdir,
    (tmpdir[strlen(tmpdir) - 1] == '/') ? "" : "/", TRAILER);
if (buf == NULL)
	return NULL;


Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message