Date: Sun, 02 Nov 2014 15:07:55 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194759] New: ports-mgmt/portlint: false positive: possible direct use of command "install" found Message-ID: <bug-194759-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194759 Bug ID: 194759 Summary: ports-mgmt/portlint: false positive: possible direct use of command "install" found Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: gerald@FreeBSD.org Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Created attachment 148933 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=148933&action=edit Patch againts portlint/src/portlint.pl Running portlint -C on emulators/wine-devel, I get the following: WARN: Makefile: [0]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead. for pre-configure: cd ${WRKSRC} && ${TAR} xf ${DISTDIR}/${COMP_DIST} --strip-components 1 cd ${WRKSRC} && ${MAKE_CMD} -C ./patches DESTDIR=${WRKSRC} install The attached patch avoids this by preventing this warning when the string "install" appears at the end of a line, since that is definitely not the case we want to warn about. Alternately you could use "\${MAKE_CMD}.*install" as a pattern. If you approve, I can commit this myself (bumping the minor version). --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer marcus@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194759-13>