From owner-freebsd-hackers@FreeBSD.ORG  Wed Oct 20 00:57:03 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id DB0551065675; Wed, 20 Oct 2010 00:57:03 +0000 (UTC)
Date: Wed, 20 Oct 2010 00:57:03 +0000
From: Alexander Best <arundel@freebsd.org>
To: Warner Losh <imp@bsdimp.com>
Message-ID: <20101020005703.GA94547@freebsd.org>
References: <201010191103.50986.jhb@freebsd.org>
	<20101019191446.GA44841@freebsd.org>
	<201010191522.21357.jhb@freebsd.org>
	<20101019.183941.41645397.imp@bsdimp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101019.183941.41645397.imp@bsdimp.com>
Cc: freebsd-hackers@FreeBSD.org, mj@feral.com, jhb@FreeBSD.org
Subject: Re: SCSI_DELAY cleanup
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Oct 2010 00:57:03 -0000

On Tue Oct 19 10, Warner Losh wrote:
> opt_scsi.h isn't needed by aha or ahb either, so it can be deleted
> entirely from their module makefiles:

thanks. :)

what about trb/Makefile? seems to build fine too without opt_scsi.h.

> 
> Index: aha/Makefile
> ===================================================================
> --- aha/Makefile	(revision 214058)
> +++ aha/Makefile	(working copy)
> @@ -4,11 +4,6 @@
>  
>  KMOD=	aha
>  SRCS=	aha.c aha_isa.c ahareg.h opt_cam.h device_if.h bus_if.h \
> -	opt_scsi.h isa_if.h
> +	isa_if.h
>  
> -.if !defined(KERNBUILDDIR)
> -opt_scsi.h:
> -	echo "#define SCSI_DELAY 15000" > ${.TARGET}
> -.endif
> -
>  .include <bsd.kmod.mk>
> Index: ahb/Makefile
> ===================================================================
> --- ahb/Makefile	(revision 214058)
> +++ ahb/Makefile	(working copy)
> @@ -3,11 +3,6 @@
>  .PATH: ${.CURDIR}/../../dev/ahb
>  
>  KMOD=	ahb
> -SRCS=	ahb.c opt_cam.h device_if.h bus_if.h eisa_if.h opt_scsi.h
> +SRCS=	ahb.c opt_cam.h device_if.h bus_if.h eisa_if.h
>  
> -.if !defined(KERNBUILDDIR)
> -opt_scsi.h:
> -	echo "#define SCSI_DELAY 15000" > ${.TARGET}
> -.endif
> -
>  .include <bsd.kmod.mk>

-- 
a13x