Date: Fri, 15 Jul 2016 05:50:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Conrad Meyer <cem@freebsd.org> Cc: Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r418510 - head/devel/elfutils Message-ID: <20160715055044.GA21041@FreeBSD.org> In-Reply-To: <CAG6CVpVbsOe%2B7viyhjk=VxYR5LXUr%2BVe0YybREYSEoTiKgZL0A@mail.gmail.com> References: <201607140142.u6E1g9Sp056312@repo.freebsd.org> <20160714084653.quyjmu7g3e4f7d5b@ivaldir.etoilebsd.net> <CAG6CVpVbsOe%2B7viyhjk=VxYR5LXUr%2BVe0YybREYSEoTiKgZL0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 14, 2016, Conrad Meyer wrote: > On Thu, Jul 14, 2016, Baptiste Daroussin <bapt@freebsd.org> wrote: > > Which is exactly why non ports committers are not supposed to commit in > > the ports tree without a ports committer review/approval. > > Sorry. I'm doing my best with the porter's handbook, just like anyone > else. As an src committer you're actually required to have your changes reviewed by active ports committer. PHB does/may not cover all possible use cases, correct practices, and it often lags behind actual `Mk/*' development. (I've made a similar point back in May in reply to r415002, where you did violate the PHB; that reply went unanswered, and the bug is still there.) > Why have a PATCH_DEPENDS distinct from BUILD_DEPENDS? It usually does not matter when building a port locally, but most automated builders would prune the dependencies between stages. This helps to make sure that dependencies are correctly specified (according to their need) as intended, and allows for more granular control of things on per-stage basis. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160715055044.GA21041>