From nobody Sun Sep 17 15:18:10 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RpWlj5cH0z4t3Sp for ; Sun, 17 Sep 2023 15:18:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RpWlj29BYz4NTm for ; Sun, 17 Sep 2023 15:18:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-52a49a42353so4464993a12.2 for ; Sun, 17 Sep 2023 08:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1694963901; x=1695568701; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SZrc39FcjD/HuyS/C00p5qVPUiZZv3DnQrPHuZQT114=; b=Vo08GC8PcETTVuHnLOn1OlajPHlebZnLaIhLo8c21ceU9rTEjBvjepvkTpraxQXCYw be1fSFAvTLWlRYzrmw57YVxLUesW6kBq/qxNNdFvUmd6t8dVWMOmZXRKMuf+i0P4COdm DFZ6v+p/Y59rk57A1NQ6eSAS0Av3IMUtqZudV8+w7bHC1FJrTgKdtEEihl860BTXlm6b QOIgqTxVaYjHarmbHaS+LTKDmQTaBb2qy1/jwAdTlCegvXsXS9e8p703jd8JML1dWgWC tlCGBYbGVw0jMK7BiYmudQjVh6GbYrF3TjnhtuYJv5/qywQv1ncP5p3PgoYV6np84zna 9hWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694963901; x=1695568701; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SZrc39FcjD/HuyS/C00p5qVPUiZZv3DnQrPHuZQT114=; b=vWZ4b2r6Ip9POt1+lVWSIRo8dXUFiC9f3KBSXvqSdqByXjz3impoUWyMeee5pIyYHx M7kwFt3G5o7hp4n+Il/psltl/ay4iIWrmHEcV3BFRkTxOr3J7az0VzkjuuItSX48ns4o 69fVlNzQfWFixZNBfcz2XTR4TN23stk3yM374Ka8xJawUXPu5JM7Zd0Z9ak39a+Ud4A6 gKEByUjyLPvaojJLkbKvK30Rnz5UeNo13pRqLKXp4EdASmVQ4zP9JfuVzG2D5WTvD1g+ m93FS097DIU9uLYQsMaAaO++a2VafBvWDii+3vNmMvLjUWeJGIbEy870TUwIqpjWxlFF t/iA== X-Gm-Message-State: AOJu0YwUENSQT7INkeaeew9mfyYYMvLOPABcw1v1UbLSabEhoQNfob9M 2KhwxRTJo3Y1aEHa167dS5K6MBjZAoQ6SzzdRuDkVQ== X-Google-Smtp-Source: AGHT+IGZ2ysVogMPxYJtd8ly+0xLSSt5mz1kHacOn6kt8WkNN0n1pQQeBn2Vak7fBNwdDQqL54SMEmoPpc7mv//fw7U= X-Received: by 2002:a05:6402:b32:b0:52f:2bd3:6f4d with SMTP id bo18-20020a0564020b3200b0052f2bd36f4dmr5302901edb.0.1694963901223; Sun, 17 Sep 2023 08:18:21 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202309171516.38HFGUnx089987@gitrepo.freebsd.org> In-Reply-To: <202309171516.38HFGUnx089987@gitrepo.freebsd.org> From: Warner Losh Date: Sun, 17 Sep 2023 16:18:10 +0100 Message-ID: Subject: Re: git: 5d51862412a8 - main - Restrict the glibc compat cookie open functions to __BSD_VISIBLE To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000003d6fa906058f8971" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4RpWlj29BYz4NTm --0000000000003d6fa906058f8971 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 17, 2023 at 4:16=E2=80=AFPM Warner Losh wrote= : > The branch main has been updated by imp: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D5d51862412a8ad246f414c7071999b6= 815080884 > > commit 5d51862412a8ad246f414c7071999b6815080884 > Author: Warner Losh > AuthorDate: 2023-09-15 16:13:11 +0000 > Commit: Warner Losh > CommitDate: 2023-09-17 15:11:57 +0000 > > Restrict the glibc compat cookie open functions to __BSD_VISIBLE > > Sponsored by: Netflix > Reviewed by: kib@ Differential Revision: https://reviews.freebsd.org/D41878 > --- > include/stdio.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/stdio.h b/include/stdio.h > index b7c412c81da7..9881b3f07329 100644 > --- a/include/stdio.h > +++ b/include/stdio.h > @@ -415,6 +415,7 @@ FILE *funopen(const void *, > #define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0) > #define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0) > > +#if __BSD_VISIBLE > typedef __ssize_t cookie_read_function_t(void *, char *, size_t); > typedef __ssize_t cookie_write_function_t(void *, const char *, size_t); > typedef int cookie_seek_function_t(void *, off64_t *, int); > @@ -426,6 +427,7 @@ typedef struct { > cookie_close_function_t *close; > } cookie_io_functions_t; > FILE *fopencookie(void *, const char *, cookie_io_functions_t); > +#endif > > /* > * Portability hacks. See . > --0000000000003d6fa906058f8971 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Sep 17, 2023 at 4:16=E2=80=AF= PM Warner Losh <imp@freebsd.org&g= t; wrote:
The br= anch main has been updated by imp:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D5d51862412a8ad246f414c7071999b6815080884
commit 5d51862412a8ad246f414c7071999b6815080884
Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
AuthorDate: 2023-09-15 16:13:11 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-09-17 15:11:57 +0000

=C2=A0 =C2=A0 Restrict the glibc compat cookie open functions to __BSD_VISI= BLE

=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Netflix=

Reviewed by: kib@
Differenti= al Revision:=C2=A0https://re= views.freebsd.org/D41878
=C2=A0
---
=C2=A0include/stdio.h | 2 ++
=C2=A01 file changed, 2 insertions(+)

diff --git a/include/stdio.h b/include/stdio.h
index b7c412c81da7..9881b3f07329 100644
--- a/include/stdio.h
+++ b/include/stdio.h
@@ -415,6 +415,7 @@ FILE=C2=A0 =C2=A0 =C2=A0 =C2=A0 *funopen(const void *,<= br> =C2=A0#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 fropen(cookie, fn) funopen(cookie,= fn, 0, 0, 0)
=C2=A0#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 fwopen(cookie, fn) funopen(cookie,= 0, fn, 0, 0)

+#if __BSD_VISIBLE
=C2=A0typedef __ssize_t cookie_read_function_t(void *, char *, size_t);
=C2=A0typedef __ssize_t cookie_write_function_t(void *, const char *, size_= t);
=C2=A0typedef int cookie_seek_function_t(void *, off64_t *, int);
@@ -426,6 +427,7 @@ typedef struct {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cookie_close_function_t *close;
=C2=A0} cookie_io_functions_t;
=C2=A0FILE=C2=A0 =C2=A0*fopencookie(void *, const char *, cookie_io_functio= ns_t);
+#endif

=C2=A0/*
=C2=A0 * Portability hacks.=C2=A0 See <sys/types.h>.
--0000000000003d6fa906058f8971--