From owner-svn-src-all@FreeBSD.ORG Sun Jul 25 20:40:34 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8367B106566B; Sun, 25 Jul 2010 20:40:34 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id 1CAB28FC16; Sun, 25 Jul 2010 20:40:33 +0000 (UTC) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 96E4514DC2E1; Sun, 25 Jul 2010 22:40:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at server.mypc.hu Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id czZ6QDTnucSm; Sun, 25 Jul 2010 22:40:30 +0200 (CEST) Received: from [192.168.1.105] (catv-80-99-92-167.catv.broadband.hu [80.99.92.167]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id C1A2D14DC212; Sun, 25 Jul 2010 22:40:29 +0200 (CEST) Message-ID: <4C4CA13C.1090502@FreeBSD.org> Date: Sun, 25 Jul 2010 22:40:28 +0200 From: Gabor Kovesdan User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-PT; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5 MIME-Version: 1.0 To: Doug Barton References: <201007251857.o6PIvmoS031484@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, delphij@freebsd.org Subject: Re: svn commit: r210479 - head/usr.bin/grep X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jul 2010 20:40:34 -0000 Em 2010.07.25. 22:17, Doug Barton escreveu: > On Sun, 25 Jul 2010, Gabor Kovesdan wrote: > >> Author: gabor >> Date: Sun Jul 25 18:57:48 2010 >> New Revision: 210479 >> URL: http://svn.freebsd.org/changeset/base/210479 >> >> Log: >> - Fix -l and -L by really surpressing output and just showing filenames >> >> Submitted by: swell.k@gmail.com > > .... and dougb. :) (It was part of the patch I sent on Friday.) I had to merge your patch with another one that I had in my working copy and I didn't catch this part. Sorry for that, it was my mistake. > > And not to pile on, but regression testing should have caught this. > First by you, and if all else fails, by your mentor. At very least the > thought process could have gone something like: "Let's see, the patch > that I/Gabor generated to fix this problem is different than the one > Doug generated. Now Doug is not a _complete_ moron, so let's take a > careful look at this change and see if it really does what we think it > should do." Nobody told that you were a moron and I did run regression testing, the test suite that GNU grep has. It passes a good number of them and some only fail because of their non-standard regexes and GNU-specific idiotism, like whether gnu --help contains the "Report bugs to ." . Even the GNU version that we have in base fails on 6 tests of latest GNU grep's test suite. Regression testing is good but sometimes real users are necessary to axe out bugs and I think we are going into the right direction and I still don't consider importing BSD grep a mistake. Bugs might appear but as you can see I'm trying to fix them asap and grep is improving in this way. Although grep seems to be a little silly utility on the top of the regex library, it's quite complex and it involves a lot of things, like the GNU regex syntax. That's why it took so long to get it to base. There were 4 exp-runs and varios CFTs but these bugs haven't been found so far so I think this broader exposure was quite a good decision. > > Aside from the fact that despite its innocuous appearance grep really > is an important tool; I've expressed frustration in the past that > mentors are not in place to simply rubber stamp things. Mentors serve > at least 2 critical functions; to introduce mentees to "The FreeBSD > Culture," and to sanity-check changes. No matter how technically > competent the mentee is (and obviously Gabor is a sharp guy) both of > these functions are critical to their successful introduction into the > wonderful world of DougBS^W I mean, uh, FreeBSD. :) My mentor really helped a lot and made lots of suggestions to improve the code but he's also a human being, he can't see everything either. :) These bugs survived lots of testing and review so it's not a surprise that he didn't found them either. Let's not flame about it any more just concentrate on bugfixing. Please send me more reports if you find anything. Gabor