From owner-cvs-all@FreeBSD.ORG  Thu Jul 15 05:02:25 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C4B3F16A4CE; Thu, 15 Jul 2004 05:02:25 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BDC3D43D46; Thu, 15 Jul 2004 05:02:25 +0000 (GMT)
	(envelope-from bmilekic@FreeBSD.org)
Received: from freefall.freebsd.org (bmilekic@localhost [127.0.0.1])
	i6F52PaF087752;	Thu, 15 Jul 2004 05:02:25 GMT
	(envelope-from bmilekic@freefall.freebsd.org)
Received: (from bmilekic@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6F52P8e087751;
	Thu, 15 Jul 2004 05:02:25 GMT
	(envelope-from bmilekic)
Date: Thu, 15 Jul 2004 05:02:25 +0000
From: Bosko Milekic <bmilekic@FreeBSD.org>
To: Alfred Perlstein <alfred@FreeBSD.org>
Message-ID: <20040715050225.GA87532@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jul 2004 05:02:25 -0000


  Why on earth would you move that first printf in boot() to inside
  the loop and introduce a variable to not reprint it after the first
  iteration?

  Also, why do you copy the proc name to the stack lower in
  kern_shutdown.c?  Do you fear that the proc might change from
  under you when you're at the bottom and you can't therefore
  only keep a reference to the proc instead?

-Bosko 

alfred      2004-07-15 04:29:48 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_shutdown.c vfs_subr.c
  Log:
  Tidy up system shutdown.

  Revision  Changes    Path
  1.156     +13 -5     src/sys/kern/kern_shutdown.c
  1.511     +11 -1     src/sys/kern/vfs_subr.c