From owner-freebsd-audit Wed Jul 18 5:44:50 2001 Delivered-To: freebsd-audit@freebsd.org Received: from columbus.cris.net (ns.cris.net [212.110.128.65]) by hub.freebsd.org (Postfix) with ESMTP id D9E3B37B403; Wed, 18 Jul 2001 05:44:40 -0700 (PDT) (envelope-from phantom@phantom.cris.net) Received: from phantom.cris.net (phantom.cris.net [212.110.130.74]) by columbus.cris.net (8.9.3/8.9.3) with ESMTP id PAA04459; Wed, 18 Jul 2001 15:44:28 +0300 (EEST) Received: (from phantom@localhost) by phantom.cris.net (8.11.1/8.11.1) id f6ICiPJ66208; Wed, 18 Jul 2001 15:44:25 +0300 (EEST) (envelope-from phantom) Date: Wed, 18 Jul 2001 15:44:25 +0300 From: Alexey Zelkin To: Mike Barcroft Cc: audit@FreeBSD.org, Dag-Erling Smorgrav Subject: Re: whois(1) changes Message-ID: <20010718154425.A65945@phantom.cris.net> References: <20010717214524.A51455@coffee.q9media.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010717214524.A51455@coffee.q9media.com>; from mike@FreeBSD.org on Tue, Jul 17, 2001 at 09:45:24PM -0400 X-Operating-System: FreeBSD 4.2-STABLE i386 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG hi, On Tue, Jul 17, 2001 at 09:45:24PM -0400, Mike Barcroft wrote: > > I would appreciate comments on the patch to whois(1) located at the > end of this e-mail and also available at: > http://people.FreeBSD.org/~mike/patches/whois.20010718.patch > > If there are no objections, I plan on committing it in a two days. > > --------------------------------------------------------------------- > > whois.20010717.patch > > o Reintegrate part of phantom's patch which adds gethostinfo(). > o Create a wrapper for asprintf(3) which checks for failure. > o Tested on i386, alpha. [patch skiped] 1. isdigit()'s argument should be explicitly casted to 'unsigned char' per ache's guidelines. 2. I think it's time to go thru include files and cleanup it. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message