From owner-freebsd-current@freebsd.org Tue Aug 18 12:58:28 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5026E3BAD35 for ; Tue, 18 Aug 2020 12:58:28 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BW9vS0pdVz41rx for ; Tue, 18 Aug 2020 12:58:28 +0000 (UTC) (envelope-from david@catwhisker.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1BB553BAD33; Tue, 18 Aug 2020 12:58:28 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B7CA3BB05F for ; Tue, 18 Aug 2020 12:58:28 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from mx.catwhisker.org (mx.catwhisker.org [107.204.234.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BW9vR026Nz41ml for ; Tue, 18 Aug 2020 12:58:26 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.16.1/8.15.2) with ESMTP id 07ICwPmJ027561; Tue, 18 Aug 2020 12:58:25 GMT (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.16.1/8.16.1/Submit) id 07ICwPMP027560; Tue, 18 Aug 2020 05:58:25 -0700 (PDT) (envelope-from david) Date: Tue, 18 Aug 2020 05:58:25 -0700 From: David Wolfskill To: Mateusz Guzik Cc: current@freebsd.org Subject: Re: "panic: malloc(M_WAITOK) in non-sleepable context" after r364296 -> r364341 Message-ID: <20200818125825.GP1394@albert.catwhisker.org> Reply-To: current@freebsd.org Mail-Followup-To: current@freebsd.org, Mateusz Guzik References: <20200818124419.GO1394@albert.catwhisker.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xP4xvRzdEG0QZ+Pj" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4BW9vR026Nz41ml X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.59 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[current@freebsd.org]; FREEFALL_USER(0.00)[david]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:107.204.234.170:c]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; DMARC_NA(0.00)[catwhisker.org]; SIGNED_PGP(-2.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.19)[-0.186]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:7018, ipnet:107.192.0.0/12, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 12:58:28 -0000 --xP4xvRzdEG0QZ+Pj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 18, 2020 at 02:48:47PM +0200, Mateusz Guzik wrote: > see https://reviews.freebsd.org/D26027 > .... Right; I was just reviewing the list of updated files and noted src/sys/kern/kern_malloc.c, and its svn log showed: ------------------------------------------------------------------------ r364310 | glebius | 2020-08-17 08:37:08 -0700 (Mon, 17 Aug 2020) | 8 lines With INVARIANTS panic immediately if M_WAITOK is requested in a non-sleepable context. Previously only _sleep() would panic. This will catch misuse of M_WAITOK at development stage rather than at stress load stage. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D26027 ------------------------------------------------------------------------ And if we were still going in to the office, I'd discuss it with Gleb. :-) But in the mean time: I'm not a committer; I didn't cause the error. Seems I can't try running head now with a GENERIC kernel. Peace, david --=20 David H. Wolfskill david@catwhisker.org Donald Trump is either ignorant of how to govern or is refusing to do so. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --xP4xvRzdEG0QZ+Pj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE4owz2QxMJyaxAefyQLJg+bY2PckFAl870HFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEUy OEMzM0Q5MEM0QzI3MjZCMTAxRTdGMjQwQjI2MEY5QjYzNjNEQzkACgkQQLJg+bY2 PcnT8QgAkVRRNjyVakVRitID8d9WSEvKJcRZx9ICemFxZFuvHthIJzrwvRSZ7aq/ dh2/JnYXOFcxV5WMexASAtdcHgkziUddxJe5vhPoaV6jXiocYQTdGyOZEeLphKhU k6rW+5SlqLdP2kqFIR2tFF3pkkNuNfhjdAWKY/RwRpFcOEG4bQ6U+9tV9T7Ktj/3 Nlef9tpYhLaDraYjRgiEQL1q8AE6jQ5hrSG3NOO8PnfdUlzqkYB9o/cbJn0s/fyX B46OwFbIsKQR5eKrF+NLwNpI+1HDrP6rYHAox7zb/lHTvk5fnnZh0bevwZ07080v kPp0kdhZqw623gX9prBxbd9ni/NRgg== =OxMD -----END PGP SIGNATURE----- --xP4xvRzdEG0QZ+Pj--