From owner-freebsd-fs@FreeBSD.ORG  Wed Aug 25 14:43:42 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 063DB1065693
	for <freebsd-fs@freebsd.org>; Wed, 25 Aug 2010 14:43:42 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B9F88FC1A
	for <freebsd-fs@freebsd.org>; Wed, 25 Aug 2010 14:43:40 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA04986;
	Wed, 25 Aug 2010 17:43:32 +0300 (EEST)
	(envelope-from avg@icyb.net.ua)
Message-ID: <4C752C13.3080508@icyb.net.ua>
Date: Wed, 25 Aug 2010 17:43:31 +0300
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.8) Gecko/20100823 Lightning/1.0b2 Thunderbird/3.1.2
MIME-Version: 1.0
To: Ollivier Robert <roberto@keltia.freenix.fr>
References: <20100811014919.GA52992@icarus.home.lan>	<20100811192537.GA44635@tolstoy.tols.org>	<AANLkTin-YvEzoN-ThwwDAqn2mWFMD4-7BnP8N95EqTk0@mail.gmail.com>	<20100811214302.GB44635@tolstoy.tols.org>	<20100812205625.GA79515@server.vk2pj.dyndns.org>	<20100824150035.GB99477@roberto-al.eurocontrol.fr>	<20100824200527.GC11990@server.vk2pj.dyndns.org>	<4C742C8F.2030401@icyb.net.ua>	<20100824215508.GA15597@lonrach.keltia.net>	<4C744417.8080106@icyb.net.ua>
	<20100825132131.GA56434@roberto-al.eurocontrol.fr>
In-Reply-To: <20100825132131.GA56434@roberto-al.eurocontrol.fr>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@freebsd.org
Subject: Re: zfs arc - just take it all and be good to me
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2010 14:43:42 -0000

on 25/08/2010 16:21 Ollivier Robert said the following:
> According to Andriy Gapon:
>> Could you please double-check?  Is the check for vm_paging_needed() indeed?
>> That could have been a slightly different patch.
> 
> 695 [15:19] root@centre:src/sys# svn diff cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c
> Index: cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c
> ===================================================================
> --- cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c    (revision 210515)
> +++ cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c    (working copy)
> @@ -2123,8 +2123,9 @@
>         /*
>          * If pages are needed or we're within 2048 pages
>          * of needing to page need to reclaim
> +     * XXX Try to workaround zfs overzealousness from gav/avg
>          */
> -       if (vm_pages_needed || (vm_paging_target() > -2048))
> +       if (vm_pages_needed)
>                 return (1);

Note that vm_pages_needed != vm_paging_needed().
Talk about confusing :)

-- 
Andriy Gapon