From owner-p4-projects@FreeBSD.ORG Tue Jul 22 06:27:47 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id CF5B637B404; Tue, 22 Jul 2003 06:27:46 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CEBA37B401; Tue, 22 Jul 2003 06:27:46 -0700 (PDT) Received: from godel.mtl.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 902A243FD7; Tue, 22 Jul 2003 06:27:45 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: from godel.mtl.distributel.net (localhost [127.0.0.1]) h6M9VpEH058317; Tue, 22 Jul 2003 09:31:51 GMT (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by godel.mtl.distributel.net (8.12.9/8.12.9/Submit) id h6M9Vp2A058316; Tue, 22 Jul 2003 09:31:51 GMT X-Authentication-Warning: godel.mtl.distributel.net: bmilekic set sender to bmilekic@technokratis.com using -f Date: Tue, 22 Jul 2003 09:31:51 +0000 From: Bosko Milekic To: Peter Wemm Message-ID: <20030722093151.GC58118@technokratis.com> References: <200307220347.h6M3lZea038684@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307220347.h6M3lZea038684@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: Perforce Change Reviews Subject: Re: PERFORCE change 34815 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:27:47 -0000 On Mon, Jul 21, 2003 at 08:47:35PM -0700, Peter Wemm wrote: > http://perforce.freebsd.org/chv.cgi?CH=34815 > > Change 34815 by peter@peter_hammer on 2003/07/21 20:47:23 > > mb_alloc and mb_free are way too big to inline They're only inlined in some local routines. Some care was taken to keep the local routines' size not too bad by only inlining them in there once or twice at worse. In retrospect, though, this could have been done better, but out-of-lining them is not the best solution. P.S.: How expensive, relatively, is a function call on the hammer? I seem to recall the alpha had a relatively higher cost (when compared to i386) for typical function calls. -- Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org TECHNOkRATIS Consulting Services * http://www.technokratis.com/