Date: Sat, 24 Mar 2012 23:00:21 GMT
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: ports/166381: bsd.port.mk: COPYTREE_* doesn't respect ${CHMOD}
Message-ID: <201203242300.q2ON0Lu5020314@freefall.freebsd.org>
Resent-Message-ID: <201203242310.q2ONABiv029250@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166381
>Category: ports
>Synopsis: bsd.port.mk: COPYTREE_* doesn't respect ${CHMOD}
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 24 23:10:11 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Jason Helfman
>Release: FreeBSD 8.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 8.2-STABLE FreeBSD 8.2-STABLE #5 r227907: Wed Nov 23 21:55:50 UTC 2011 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386
>Description:
COPYTREE_ macros use chmod, when they should be respecting ${CHMOD} and not overwriting defines in individual ports that use this functionality.
>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.708
diff -u -r1.708 bsd.port.mk
--- bsd.port.mk 13 Mar 2012 08:14:45 -0000 1.708
+++ bsd.port.mk 24 Mar 2012 22:56:23 -0000
@@ -2375,22 +2375,22 @@
COPYTREE_BIN= ${SH} -c '(${FIND} -d $$0 $$2 | ${CPIO} -dumpl $$1 >/dev/null \
2>&1) && \
${CHOWN} -R ${BINOWN}:${BINGRP} $$1 && \
- ${FIND} -d $$0 $$2 -type d -exec chmod 755 $$1/{} \; && \
- ${FIND} -d $$0 $$2 -type f -exec chmod ${BINMODE} $$1/{} \;' --
+ ${FIND} -d $$0 $$2 -type d -exec ${CHMOD} 755 $$1/{} \; && \
+ ${FIND} -d $$0 $$2 -type f -exec ${CHMOD} ${BINMODE} $$1/{} \;' --
COPYTREE_SHARE= ${SH} -c '(${FIND} -d $$0 $$2 | ${CPIO} -dumpl $$1 >/dev/null \
2>&1) && \
${CHOWN} -R ${SHAREOWN}:${SHAREGRP} $$1 && \
- ${FIND} -d $$0 $$2 -type d -exec chmod 755 $$1/{} \; && \
- ${FIND} -d $$0 $$2 -type f -exec chmod ${SHAREMODE} $$1/{} \;' --
+ ${FIND} -d $$0 $$2 -type d -exec ${CHMOD} 755 $$1/{} \; && \
+ ${FIND} -d $$0 $$2 -type f -exec ${CHMOD} ${SHAREMODE} $$1/{} \;' --
.else
COPYTREE_BIN= ${SH} -c '(${FIND} -d $$0 $$2 | ${CPIO} -dumpl $$1 >/dev/null \
2>&1) && \
- ${FIND} -d $$0 $$2 -type d -exec chmod 755 $$1/{} \; && \
- ${FIND} -d $$0 $$2 -type f -exec chmod ${BINMODE} $$1/{} \;' --
+ ${FIND} -d $$0 $$2 -type d -exec ${CHMOD} 755 $$1/{} \; && \
+ ${FIND} -d $$0 $$2 -type f -exec ${CHMOD} ${BINMODE} $$1/{} \;' --
COPYTREE_SHARE= ${SH} -c '(${FIND} -d $$0 $$2 | ${CPIO} -dumpl $$1 >/dev/null \
2>&1) && \
- ${FIND} -d $$0 $$2 -type d -exec chmod 755 $$1/{} \; && \
- ${FIND} -d $$0 $$2 -type f -exec chmod ${SHAREMODE} $$1/{} \;' --
+ ${FIND} -d $$0 $$2 -type d -exec ${CHMOD} 755 $$1/{} \; && \
+ ${FIND} -d $$0 $$2 -type f -exec ${CHMOD} ${SHAREMODE} $$1/{} \;' --
.endif
# The user can override the NO_PACKAGE by specifying this from
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203242300.q2ON0Lu5020314>