From owner-svn-src-all@FreeBSD.ORG Wed Oct 20 09:35:21 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E0621065672; Wed, 20 Oct 2010 09:35:21 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3C86B8FC1C; Wed, 20 Oct 2010 09:35:21 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o9K9ZLha044516; Wed, 20 Oct 2010 09:35:21 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o9K9ZLdd044514; Wed, 20 Oct 2010 09:35:21 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <201010200935.o9K9ZLdd044514@svn.freebsd.org> From: Ed Schouten Date: Wed, 20 Oct 2010 09:35:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r214105 - head/usr.bin/truss X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2010 09:35:21 -0000 Author: ed Date: Wed Oct 20 09:35:20 2010 New Revision: 214105 URL: http://svn.freebsd.org/changeset/base/214105 Log: Remove setpgid() call before executing child process. Using a separate process group here is bad, since (for example) job control in the TTY layer prevents interaction with the TTY, causing the child process to hang. Mentioned on: current@ MFC after: 2 weeks Modified: head/usr.bin/truss/setup.c Modified: head/usr.bin/truss/setup.c ============================================================================== --- head/usr.bin/truss/setup.c Wed Oct 20 07:54:43 2010 (r214104) +++ head/usr.bin/truss/setup.c Wed Oct 20 09:35:20 2010 (r214105) @@ -78,7 +78,6 @@ setup_and_wait(char *command[]) } if (pid == 0) { /* Child */ ptrace(PT_TRACE_ME, 0, 0, 0); - setpgid (0, 0); execvp(command[0], command); err(1, "execvp %s", command[0]); }