From owner-cvs-src@FreeBSD.ORG Mon Jan 14 01:35:11 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC2FB16A419; Mon, 14 Jan 2008 01:35:11 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DA2D513C469; Mon, 14 Jan 2008 01:35:09 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <478ABC4B.8080601@FreeBSD.org> Date: Mon, 14 Jan 2008 02:35:07 +0100 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Tim Kientzle References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> In-Reply-To: <478AA9E4.2010807@kientzle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Tim Kientzle , cvs-all@FreeBSD.org, Dag-Erling Smorgrav , src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 01:35:12 -0000 Tim Kientzle wrote: >>> Of course, giving those four ports a build-time dependency >>> on the Info-Zip version is arguably the right approach >>> in any case. >> >> That would probably be undesirable because it would mean having to >> special case things in the ports tree and/or duplicate code. > > I'm confused. How is it different from having > a build-time dependency on GNU tar? I thought > I remembered a few cases where ports installed > GNU tar (as a build dependency) and then extracted > with GNU tar. > > This case would seem no different. But I'm far > less familiar with the details than you are, so > I'll happily bow to your expertise in the matter. > > Tim Kientzle These ports currently obtain the unzip port dependency by setting USE_ZIP, and then everything just works, i.e. there is logic in bsd.port.mk to handle things like distfile extraction. If we have to special case ports to deal with variant zipfiles that cannot be processed by /usr/bin/unzip then it gets messier because we have to account for some ports being satisfied with USE_ZIP=yes meaning /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd prefer not to have to add those workarounds. Kris