Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Jan 2008 02:35:07 +0100
From:      Kris Kennaway <kris@FreeBSD.org>
To:        Tim Kientzle <tim@kientzle.com>
Cc:        cvs-src@FreeBSD.org, Tim Kientzle <kientzle@FreeBSD.org>, cvs-all@FreeBSD.org, Dag-Erling Smorgrav <des@FreeBSD.org>, src-committers@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c
Message-ID:  <478ABC4B.8080601@FreeBSD.org>
In-Reply-To: <478AA9E4.2010807@kientzle.com>
References:  <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Tim Kientzle wrote:
>>> Of course, giving those four ports a build-time dependency
>>> on the Info-Zip version is arguably the right approach
>>> in any case.
>>
>> That would probably be undesirable because it would mean having to 
>> special case things in the ports tree and/or duplicate code.
> 
> I'm confused.  How is it different from having
> a build-time dependency on GNU tar?  I thought
> I remembered a few cases where ports installed
> GNU tar (as a build dependency) and then extracted
> with GNU tar.
> 
> This case would seem no different.  But I'm far
> less familiar with the details than you are, so
> I'll happily bow to your expertise in the matter.
> 
> Tim Kientzle

These ports currently obtain the unzip port dependency by setting 
USE_ZIP, and then everything just works, i.e. there is logic in 
bsd.port.mk to handle things like distfile extraction.

If we have to special case ports to deal with variant zipfiles that 
cannot be processed by /usr/bin/unzip then it gets messier because we 
have to account for some ports being satisfied with USE_ZIP=yes meaning 
/usr/bin/unzip and some still requiring /usr/ports/archivers/unzip.  I'd 
prefer not to have to add those workarounds.

Kris



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?478ABC4B.8080601>