From nobody Thu Jul 27 16:03:55 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RBbDC3Dpkz4pnv4; Thu, 27 Jul 2023 16:03:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RBbDC2Q63z4Bnb; Thu, 27 Jul 2023 16:03:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690473835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q2XJgzYFSyQAJyP8RQqOdDJ7P7k8hQ5685CAwmp2P9c=; b=NHBpKXSd5PqEEKuVjQLMqQ+RbHos4bLRgTSX7sdNUr0HQ8y7nAyCVwGlHuae+6RZ7bjRvW Th3ilqVy8Vle3BVNVajvKVoyuzqg5ZPLRYodMJvG+Bw8l2dePDibcwLjTVMZMQYnUh7Ir1 LH+VvH7rPCvTGLbk29lqWVbUqZ7KRLYiqBms3V2W3YPjU5Rihexw/HFzp58Nwi5/dn3KQr aBk35XscBiYbT38CKVsHmIiFXiXKEK+cjs4TxFis8LSo5XzoiP6iT5TdFIdlTNn8+sj3VT 8adWLEo2Cm3HKMbPjtUTmcbH862W4CoRSw2212BXN44lQftmRUFx79eU+fzlyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690473835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q2XJgzYFSyQAJyP8RQqOdDJ7P7k8hQ5685CAwmp2P9c=; b=iiIsmLK0LEA9rg7Vaiy4/9MRwuV+fFVYTWlsI9MC8nHB8d1A5urX+xBvzB58LIumQpR4Gf ZP0NPmLScEqIY7CyRIoTfnRf56AILarHnicO45RlIX+Fxjv4ThzUFC21+GNMzuVNRFXUMr YOURMXjzwVGVi60V5QLcuPADqfVZkyK2LUydHAqARpiMIQvillOMDomQs4CnlpvxhqFJ+r 3vBalIrjKqa0aABfer6gFs2+HTL3r4MnXsiQ7qzcLouYJAWTUg1SadoYeuUbZA3kFp2GEK /zEHJ7jeuDX6bIY9cGdgeC9P/ZppRV3eZ3uJbwJVvtlwnImF1MVKdRfxt+kIuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690473835; a=rsa-sha256; cv=none; b=wS9uXQ+qYTlybMyQt/zhy+zlxK4mg1QNqvyNMt8Y4ej3iAmL4f4V8DS1UoN0xaIn8sH2jv ZE9RhKhXkvdSLoGeJQbfEImgOYI60zBaAkAff3WEnKVJU2/IcDdxPIlQb5bFe/ro6Yte9Z 1LP8pfSgsrfGq4ZU65roCo7QVqHIvqxCv27aHFZm6f49gTjR1Ue+ZJaMQtBlWZyboT/7Tl 0Z2HX2iojHKf7CLIT7gb5+iYsEqbeYmSfT1Po+nJzub/BhTh/Dv1qM6iqFJmIN810rMaS6 OkUs+J5sOiVTMYSMyTq/nhVqCmM1Hgtwpxhm0RMtVkd1ovNlT94RgivRoQ1IXA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RBbDC1Lc2zGF8; Thu, 27 Jul 2023 16:03:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 36RG3tnS073713; Thu, 27 Jul 2023 16:03:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 36RG3tnb073712; Thu, 27 Jul 2023 16:03:55 GMT (envelope-from git) Date: Thu, 27 Jul 2023 16:03:55 GMT Message-Id: <202307271603.36RG3tnb073712@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: cf32543fa4fa - main - tcp: document that conditional fields in tcpcb should be at the end List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cf32543fa4faded1b1d17f7aa1335cd249320088 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=cf32543fa4faded1b1d17f7aa1335cd249320088 commit cf32543fa4faded1b1d17f7aa1335cd249320088 Author: Michael Tuexen AuthorDate: 2023-07-27 07:02:19 +0000 Commit: Michael Tuexen CommitDate: 2023-07-27 07:02:19 +0000 tcp: document that conditional fields in tcpcb should be at the end Reviewed by: rscheff, Peter Lei Sponsored by: Netflix, Inc. --- sys/netinet/tcp_var.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h index 0f57fec74865..d6d071676089 100644 --- a/sys/netinet/tcp_var.h +++ b/sys/netinet/tcp_var.h @@ -471,6 +471,11 @@ struct tcpcb { }; struct osd t_osd; /* storage for Khelp module data */ uint8_t _t_logpoint; /* Used when a BB log points is enabled */ + /* + * Keep all #ifdef'ed components at the end of the structure! + * This is important to minimize problems when compiling modules + * using this structure from within the modules' directory. + */ #ifdef TCP_REQUEST_TRK /* Response tracking addons. */ uint8_t t_tcpreq_req; /* Request count */