From owner-p4-projects@FreeBSD.ORG  Wed Aug 16 15:10:58 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 997FE16A4E9; Wed, 16 Aug 2006 15:10:58 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 77CD216A4E5;
	Wed, 16 Aug 2006 15:10:58 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7269D43D5A;
	Wed, 16 Aug 2006 15:10:57 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k7GFAivT039350;
	Wed, 16 Aug 2006 11:10:55 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Roman Divacky <rdivacky@freebsd.org>
Date: Wed, 16 Aug 2006 11:03:38 -0400
User-Agent: KMail/1.9.1
References: <200608161457.k7GEv1YG077040@repoman.freebsd.org>
In-Reply-To: <200608161457.k7GEv1YG077040@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200608161103.38724.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]);
	Wed, 16 Aug 2006 11:10:56 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.88.3/1669/Wed Aug 16 07:54:21 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 104242 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Aug 2006 15:10:58 -0000

On Wednesday 16 August 2006 10:57, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=104242
> 
> Change 104242 by rdivacky@rdivacky_witten on 2006/08/16 14:56:54
> 
> 	Return p->p_ptr->p_pid in getppid directly instead of using 2.6 infrastructure.

You'll need to hold PROC_LOCK if not already to ensure p_pptr is valid while you dereference it.

> Affected files ...
> 
> .. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_misc.c#18 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_misc.c#18 (text+ko) ====
> 
> @@ -1392,7 +1392,7 @@
>  		if (strlen(osrel) >= 3 && osrel[2] == '6')
>     			td->td_retval[0] = em->shared->group_pid;
>  		else
> -		   	td->td_retval[0] = pp->p_pid;
> +		   	td->td_retval[0] = p->p_pptr->p_pid;
>  	} else
>  	   	td->td_retval[0] = pp->p_pid;
>  
> 

-- 
John Baldwin