From owner-freebsd-current@FreeBSD.ORG  Thu Nov 20 19:52:09 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4DD8B16A519
	for <freebsd-current@FreeBSD.ORG>;
	Thu, 20 Nov 2003 19:52:09 -0800 (PST)
Received: from franky.speednet.com.au (franky.speednet.com.au [203.57.65.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0D84E43FCB
	for <freebsd-current@FreeBSD.ORG>;
	Thu, 20 Nov 2003 19:52:08 -0800 (PST)
	(envelope-from andyf@speednet.com.au)
Received: from hewey.af.speednet.com.au (udsl-3-062.QLD.dft.com.au
	[202.168.108.62])hAL3q6RZ047510	for <freebsd-current@FreeBSD.ORG>;
	Fri, 21 Nov 2003 14:52:06 +1100 (EST)
	(envelope-from andyf@speednet.com.au)
Received: from hewey.af.speednet.com.au (hewey.af.speednet.com.au
	[172.22.2.17])hAL3q5UR073663	for <freebsd-current@FreeBSD.ORG>;
	Fri, 21 Nov 2003 13:52:06 +1000 (EST)
	(envelope-from andyf@speednet.com.au)
Date: Fri, 21 Nov 2003 13:52:05 +1000 (EST)
From: Andy Farkas <andyf@speednet.com.au>
X-X-Sender: andyf@hewey.af.speednet.com.au
To: freebsd-current@FreeBSD.ORG
Message-ID: <20031121132922.Y72194@hewey.af.speednet.com.au>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: systat drive list
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 03:52:09 -0000


Low priority, but easy to accomplish:

Now that my eisa scsi disk controllers are working again, I'd like to
monitor the 8 drives attached with systat(1), except its broken.

Would someone like to commit this trivial patch?  (see pr bin/59220)


> cd /usr/src/usr.bin/systat/
> ident devs.c
devs.c:
     $FreeBSD: src/usr.bin/systat/devs.c,v 1.9 2003/10/20 20:13:50 phk Exp $
> diff -u devs.c-orig devs.c
--- devs.c-orig Fri Nov 21 13:23:33 2003
+++ devs.c      Fri Nov 21 13:46:14 2003
@@ -280,12 +280,12 @@
                        ;
                if (*cp)
                        *cp++ = '\0';
-               if (cp - args == 0)
+               if (cp - tmpstr1 == 0)
                        break;
                for (i = 0; i < num_devices; i++) {
                        asprintf(&buffer, "%s%d",
dev_select[i].device_name,
                                dev_select[i].unit_number);
-                       if (strcmp(buffer, tmpstr1) == 0) {
+                       if (strcmp(tmpstr1, buffer) == 0) {

                                num_devices_specified++;

@@ -303,8 +303,8 @@
                                free(buffer);
                }
                if (i >= num_devices)
-                       error("%s: unknown drive", args);
-               args = cp;
+                       error("%s: unknown drive", tmpstr1);
+               tmpstr1 = cp;
        }
        free(tmpstr);


--

 :{ andyf@speednet.com.au

        Andy Farkas
    System Administrator
   Speednet Communications
 http://www.speednet.com.au/