From owner-cvs-all@FreeBSD.ORG Thu May 3 17:10:03 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E42DC16A402; Thu, 3 May 2007 17:10:03 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id CF89513C48C; Thu, 3 May 2007 17:10:03 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id F28F61A4D82; Thu, 3 May 2007 10:10:38 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 17A685138E; Thu, 3 May 2007 13:10:03 -0400 (EDT) Date: Thu, 3 May 2007 13:10:02 -0400 From: Kris Kennaway To: "Mikhail T." Message-ID: <20070503171002.GA86430@xor.obsecurity.org> References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> <4639663D.1020308@freebsd.org> <20070503062438.GA50698@xor.obsecurity.org> <4639E3D0.1050208@aldan.algebra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4639E3D0.1050208@aldan.algebra.com> User-Agent: Mutt/1.4.2.2i Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Kris Kennaway , Rong-en Fan , cvs-all@freebsd.org, kientzle@freebsd.org, portmgr@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 17:10:04 -0000 On Thu, May 03, 2007 at 09:29:52AM -0400, Mikhail T. wrote: > Kris Kennaway wrote: > >On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > > > >>Rong-en Fan wrote: > >> > >>>On 3/15/07, Colin Percival wrote: > >>> > >>>> Modified files: > >>>> usr.bin/tar write.c > >>>> Log: > >>>> Don't consider an lstat(2) failure to be an error (in the sense of > >>>> affecting the return value from bsdtar) [...] > >>>> > >>>This commit makes 'make package' successfully even if the plist is > >>>wrong, i.e. it contains ``ghost'' files. Basically, > >>> > >>>$ tar zcvf a.tgz /aaa > >>>tar: /aaa: Cannot stat: No such file or directory > >>> > >>>It returns 0, so make package will be considered successful. > >>> > >>I've fixed this in revision 1.62. > >> > >>Colin Percival > >> > > > >Thanks, I think mi@ ran into this recently too. > > > So, this is fixed now? A bug is fixed, dunno off-hand it's the one you ran into. > I guess, the fears, that fixing it would require > fixing multitude of ports, were somewhat ungrounded. Relax, it was just a guess. Kris