From owner-svn-src-all@freebsd.org Wed Aug 7 20:27:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B3709B6B59; Wed, 7 Aug 2019 20:27:37 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 463jjh6m35z4Hby; Wed, 7 Aug 2019 20:27:36 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-ot1-x32c.google.com with SMTP id q20so109448574otl.0; Wed, 07 Aug 2019 13:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h7823emz+A8txgLOwhiX8ZIQX+qXPxr2GlwMIi9MVnw=; b=NhMhym77Wz3MLC7Jk4WzikyaKnHmtQ8kP4UWhEAEuThRPwffShWJyM9ozfKw4nDMsW m63uOaTS78CdwXOiekTv99B7PSJsjVRa9fP9BLmZ+SIvW3YnUp+txEqQP70MLL6x0+q1 4PPO51QttrLUHo+sArsZGFTO9CfmENzmFZmHTej3gJaBL1X4jMxI1T3rzWYo6P64QXnL CkcTMU1ee9G+g3f+XjJDwPvwBUAZBISU+5PBNza5NlnLyQ6qqouHBRtfxz7Whp4+yaNx fNV9bP8jk9JeDlqJ52xfHlVQoYLNvPSeWf7cgLm/FfcBCqFcdsKH+P3013V1KA/utdz2 La3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=h7823emz+A8txgLOwhiX8ZIQX+qXPxr2GlwMIi9MVnw=; b=J1hZRP7qSXRjzfUKeoGk6WsZrSrMPAMukbeC0oCQe7KWiV5FC6ygJk0pHyt/PhcDFU FajUXJQ6aj9k7Q3GHc6hxcZcCk1vdnUgnbUzHfP1kzsBRJH3Ot/G4msmRs/IeqWWHvSB pZ7z2jXRkZbritsf9TfjVWBxyP8i6+baLOwmR6b/5Nxj+0ci3NVFwl3z6/peCNrbbAKM 3zb4A+Sook+qic0Ww/j/va13LXyv8ig1zYu5NjQK0nCcKEb+hgbXOawnkINUFuoU4XQY nA22mmkKnTFcOigm2uOH8FaX56JIdaBsnaJU6+tp/tJDVRM1NGA8/dOMe3m8QhNIa6NO s8kQ== X-Gm-Message-State: APjAAAUYm74Wyze/IzEthhBcIwbui57q8EbuILXTGRBtTTzN512QlFb3 VbX4bkPyu73wQ8S5g42Qq2yrKYd2pSk= X-Google-Smtp-Source: APXvYqw4eQCDftgX1+aiJu+4j67DzbY8MpQRapvjZ/lzPRzNNMR+YBOElyjIroqWgjB2t8K5No81Hw== X-Received: by 2002:a5d:9bc6:: with SMTP id d6mr10206293ion.160.1565209655207; Wed, 07 Aug 2019 13:27:35 -0700 (PDT) Received: from raichu (toroon0560w-lp130-04-184-145-252-124.dsl.bell.ca. [184.145.252.124]) by smtp.gmail.com with ESMTPSA id s10sm192649922iod.46.2019.08.07.13.27.34 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 07 Aug 2019 13:27:34 -0700 (PDT) Sender: Mark Johnston Date: Wed, 7 Aug 2019 16:27:32 -0400 From: Mark Johnston To: Li-Wen Hsu Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350512 - head/tests/sys/kern Message-ID: <20190807202732.GD1377@raichu> References: <201908011819.x71IJG0M076399@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201908011819.x71IJG0M076399@repo.freebsd.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 463jjh6m35z4Hby X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NhMhym77; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::32c as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-5.63 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.94)[ip: (-9.16), ipnet: 2607:f8b0::/32(-3.03), asn: 15169(-2.43), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; RCVD_IN_DNSWL_NONE(0.00)[c.2.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[124.252.145.184.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Aug 2019 20:27:37 -0000 On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote: > Author: lwhsu > Date: Thu Aug 1 18:19:16 2019 > New Revision: 350512 > URL: https://svnweb.freebsd.org/changeset/base/350512 > > Log: > Only skip test cases sometimes failing in CI when they are running in CI > > Suggested by: jhb > Sponsored by: The FreeBSD Foundation This seems to break running the tests manually; atf dies because the "ci" variable is not defined. I have to use an invocation like this to avoid that: $ kyua -v test_suites.FreeBSD.ci=false test ptrace_test I suspect that share/mk/suite.test.mk needs to be augmented somehow to set this variable to "false" by default, so that the CI infrastructure can override that. > Modified: > head/tests/sys/kern/ptrace_test.c > > Modified: head/tests/sys/kern/ptrace_test.c > ============================================================================== > --- head/tests/sys/kern/ptrace_test.c Thu Aug 1 17:59:56 2019 (r350511) > +++ head/tests/sys/kern/ptrace_test.c Thu Aug 1 18:19:16 2019 (r350512) > @@ -258,7 +258,8 @@ ATF_TC_BODY(ptrace__parent_sees_exit_after_child_debug > int cpipe[2], dpipe[2], status; > char c; > > - atf_tc_skip("https://bugs.freebsd.org/239399"); > + if (atf_tc_get_config_var_as_bool(tc, "ci")) > + atf_tc_skip("https://bugs.freebsd.org/239399"); > > ATF_REQUIRE(pipe(cpipe) == 0); > ATF_REQUIRE((child = fork()) != -1); > @@ -801,7 +802,8 @@ ATF_TC_BODY(ptrace__follow_fork_both_attached_unrelate > pid_t children[2], fpid, wpid; > int cpipe[2], status; > > - atf_tc_skip("https://bugs.freebsd.org/239397"); > + if (atf_tc_get_config_var_as_bool(tc, "ci")) > + atf_tc_skip("https://bugs.freebsd.org/239397"); > > ATF_REQUIRE(pipe(cpipe) == 0); > ATF_REQUIRE((fpid = fork()) != -1); > @@ -871,7 +873,8 @@ ATF_TC_BODY(ptrace__follow_fork_child_detached_unrelat > pid_t children[2], fpid, wpid; > int cpipe[2], status; > > - atf_tc_skip("https://bugs.freebsd.org/239292"); > + if (atf_tc_get_config_var_as_bool(tc, "ci")) > + atf_tc_skip("https://bugs.freebsd.org/239292"); > > ATF_REQUIRE(pipe(cpipe) == 0); > ATF_REQUIRE((fpid = fork()) != -1); > @@ -936,7 +939,8 @@ ATF_TC_BODY(ptrace__follow_fork_parent_detached_unrela > pid_t children[2], fpid, wpid; > int cpipe[2], status; > > - atf_tc_skip("https://bugs.freebsd.org/239425"); > + if (atf_tc_get_config_var_as_bool(tc, "ci")) > + atf_tc_skip("https://bugs.freebsd.org/239425"); > > ATF_REQUIRE(pipe(cpipe) == 0); > ATF_REQUIRE((fpid = fork()) != -1); > @@ -2084,7 +2088,8 @@ ATF_TC_BODY(ptrace__PT_KILL_competing_stop, tc) > struct ptrace_lwpinfo pl; > struct sched_param sched_param; > > - atf_tc_skip("https://bugs.freebsd.org/220841"); > + if (atf_tc_get_config_var_as_bool(tc, "ci")) > + atf_tc_skip("https://bugs.freebsd.org/220841"); > > ATF_REQUIRE((fpid = fork()) != -1); > if (fpid == 0) { >