From owner-cvs-all Sat Jan 15 22:56:54 2000 Delivered-To: cvs-all@freebsd.org Received: from mail.xmission.com (mail.xmission.com [198.60.22.22]) by hub.freebsd.org (Postfix) with ESMTP id 60F4615220; Sat, 15 Jan 2000 22:56:50 -0800 (PST) (envelope-from wes@softweyr.com) Received: from [204.68.178.39] (helo=softweyr.com ident=wes) by mail.xmission.com with esmtp (Exim 3.03 #3) id 129jXe-0005Ui-00; Sat, 15 Jan 2000 23:52:05 -0700 Message-ID: <38816B7D.AA4A3BD6@softweyr.com> Date: Sat, 15 Jan 2000 23:55:57 -0700 From: Wes Peters Organization: Softweyr LLC X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 3.3-RELEASE i386) X-Accept-Language: en MIME-Version: 1.0 To: Jason Evans Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_sysent.c sys_generic.c syscalls.c syscalls.master uipc_socket.c uipc_socket2.c vfs_aio.c src/sys/sys aio.h socketvar.h syscall-hide.h syscall.h syscall.mk sysproto.h References: <200001140253.SAA53905@freefall.freebsd.org> <20000114105513.O302@sturm.canonware.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Jason Evans wrote: > > On Sat, Jan 15, 2000 at 01:14:09AM +1100, Bruce Evans wrote: > > > > Don't mix style fixes with new functionality. It makes the diffs hard to > > read, and hides the new bugs. This change is a particularly good bad > > example. It reformats lots of old code. The diff (-c1) is 25% larger > > than the original file. > > Okay, that makes sense. So the next time this comes up, should I check in > the style changes before or after the functionality changes? Before, if you're fixing the file so you can actually read it. If you can fix the file without fixing the style first, you should probably just leave it alone. -- "Where am I, and what am I doing in this handbasket?" Wes Peters Softweyr LLC wes@softweyr.com http://softweyr.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message