From owner-svn-src-head@FreeBSD.ORG Fri Aug 7 09:24:50 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 295E11065670; Fri, 7 Aug 2009 09:24:50 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe05.swip.net [212.247.154.129]) by mx1.freebsd.org (Postfix) with ESMTP id C63718FC0A; Fri, 7 Aug 2009 09:24:48 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=GB8WYDQo1twA:10 a=Qa35spukGxu/rmuNTmr4yg==:17 a=8kQB0OdkAAAA:8 a=6I5d2MoRAAAA:8 a=P9TsVtavG146hPkgxBsA:9 a=9YxHO_mmqpWiG0jQdLAA:7 a=OrJ2ROVjZiQDnvDjYSlunmBUMKEA:4 a=9aOQ2cSd83gA:10 Received: from [85.19.72.137] (account mc467741@c2i.net HELO laptop.adsl.tele2.no) by mailfe05.swip.net (CommuniGate Pro SMTP 5.2.13) with ESMTPA id 1190164305; Fri, 07 Aug 2009 11:24:46 +0200 From: Hans Petter Selasky To: "M. Warner Losh" Date: Fri, 7 Aug 2009 11:24:44 +0200 User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA2; KDE/4.2.4; i386; ; ) References: <20090804031407.GA8974@hub.freebsd.org> <200908070830.47894.hselasky@c2i.net> <20090807.005400.-1749708164.imp@bsdimp.com> In-Reply-To: <20090807.005400.-1749708164.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908071124.47955.hselasky@c2i.net> Cc: src-committers@freebsd.org, nparhar@gmail.com, svn-src-all@freebsd.org, alfred@freebsd.org, rwatson@freebsd.org, brde@optusnet.com.au, svn-src-head@freebsd.org Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2009 09:24:50 -0000 On Friday 07 August 2009 08:54:00 M. Warner Losh wrote: > In message: <200908070830.47894.hselasky@c2i.net> > > Hans Petter Selasky writes: > : On Thursday 06 August 2009 21:47:16 Navdeep Parhar wrote: > : > >> See attached patch. Please test and report back. > : > > > : > > This patch fixes my problem. The machine is remote and I'm unable > : > > to test whether the USB keyboard and keystroke repetition works, but > : > > core dumps to a SATA disk are now as fast as they were before > : > > r195960. Thanks. > : > > : > I finally got a chance to try a USB keyboard with ddb, and things did > : > not go too well overall. While inside ddb, keystrokes were recognized > : > properly and repetition worked too. But after exiting ddb, the > : > keyboard wouldn't work - there wasn't any visible response to > : > keystrokes. Also, I kept seeing the login prompt continually scroll > : > up, as if someone was pressing repeatedly. It certainly > : > wasn't me :-) > : > > : > Are you assuming that a user will not resume normal operation after > : > entering the debugger? A panic/reboot isn't the only exit route from > : > ddb..... > : > > : > Simple sequence of steps to reproduce problem: > : > ctrl-alt-esc on the USB keyboard > : > db> c > : > : This is like expected. > : > : Once paniced, USB operation is blocked on the USB controller which the > : keyboard belongs to, because USB does not receive any polling-complete > : call, so that it can clean up the state in the USB controller! This > : mainly has to do with avoid calling wakeup() during polling. > : > : To avoid wakeup() calls, USB sets some bits, which must be cleared when > : polling is complete, which is currently not done, because USB doesn't > : know when polling is complete ... > > Polling isn't supposed to work like this... The rest of the system > effects a poll without these side effects. Please try the following patch and report back. There is some Giant fuzz which you can ignore. I will see if I can followup a patch against -current later today. http://perforce.freebsd.org/chv.cgi?CH=167084 --HPS