Date: Tue, 17 Sep 2019 13:33:08 -0700 From: Randall Stewart <rrs@netflix.com> To: vm finance <vm.finance2@gmail.com> Cc: Jamie Landeg-Jones <jamie@catflap.org>, Ryan Stone <rysto32@gmail.com>, freebsd-net <freebsd-net@freebsd.org> Subject: Re: BBR patches? Message-ID: <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> In-Reply-To: <BCC20B79-ECEF-4D7C-AA7E-5F8A0869753A@netflix.com> References: <CAKy-8=jUu=dbp1s7nhYBwgeh%2BiO-XY-YEnh1MJ81aYJoopVonA@mail.gmail.com> <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <CAKy-8=gZ8E73PZdxb33aN=TmfigcNyTvZP4wP3M-mAy9no-v6w@mail.gmail.com> <CAFMmRNxbX5f3s0ZZk=Epr7Gu7%2Bsjat8F0TV0aX_RwoFgX0s%2ByA@mail.gmail.com> <CAKy-8=g=3LC8u_vc_3_Pfe6pgoUxpvx7N_j=xv7nRaM%2BD1Oz-A@mail.gmail.com> <D35AF884-C631-42CE-ABFD-F4AA76AA6693@netflix.com> <CAKy-8=jSdSFPJWL=cLeea-KSc=9wxR6vQTODibw7-GUh0XpCfw@mail.gmail.com> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <CAKy-8=idqzA0-Trm%2B5gZSQs=vyXrPm40gP3AsbMf_YQj-NEHaA@mail.gmail.com> <CAKy-8=jpGvKU1khALK%2Ba5Ojp7btg7y1W%2BELtTLQaniVNtgBj3g@mail.gmail.com> <AD906F45-B083-476F-952E-3318F36BD828@netflix.com> <BCC20B79-ECEF-4D7C-AA7E-5F8A0869753A@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Looking at your make file log I can’t really tell what you are doing. Its not the BBR or Rack code that is blowing up… Are you cross compiling? I have done the old fashioned kernel make i.e. cd src/sys/amd64/config config headvm cd ../compile/headvm make cleandepend ; make depend; make -j3 I have done cd src make buildkernel KERNCONF=headvm And even make buildkernel KERNCONF=GENERIC to make sure that the build works without bbr. I attach my headvm config.. What exactly are you building and how? kernel config too please? R [-- Attachment #2 --] # # GENERIC -- Generic kernel configuration file for FreeBSD/amd64 # # For more information on this file, please read the config(5) manual page, # and/or the handbook section on Kernel Configuration Files: # # http://www.FreeBSD.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig-config.html # # The handbook is also available locally in /usr/share/doc/handbook # if you've installed the doc distribution, otherwise always see the # FreeBSD World Wide Web server (http://www.FreeBSD.org/) for the # latest information. # # An exhaustive list of options and more detailed explanations of the # device lines is also present in the ../../conf/NOTES and NOTES files. # If you are in doubt as to the purpose or necessity of a line, check first # in NOTES. # # $FreeBSD$ include GENERIC ident GENERIC-NODEBUG nooptions VIMAGE #nooptions INVARIANTS #nooptions INVARIANT_SUPPORT #nooptions WITNESS #nooptions WITNESS_SKIPSPIN #nooptions BUF_TRACKING #nooptions DEADLKRES #nooptions FULL_BUF_TRACKING nooptions VIMAGE makeoptions WITH_EXTRA_TCP_STACKS=1 options TCPHPTS options KERN_TLS options RATELIMIT [-- Attachment #3 --] > On Sep 17, 2019, at 1:11 PM, Randall Stewart <rrs@netflix.com> wrote: > > looking > > I was at 352408.. let me update and try it > > R > >> On Sep 17, 2019, at 1:10 PM, Randall Stewart <rrs@netflix.com> wrote: >> >> Hmm >> >> Did you get the patch I updated too this am? >> >> I have built it both with and without the bbr stack and had no issue.. there was >> an issue with KTLS before the update though. >> >> I don’t recognize what you have below there though… >> >> R >> >>> On Sep 17, 2019, at 11:47 AM, vm finance <vm.finance2@gmail.com> wrote: >>> >>> Got it - thank you! >>> >>> btw, I tried to build the patch but its giving an error. Following is SVN info + make error mesg. >>> >>> Please let me know what am I missing here? >>> >>> Thanks! >>> >>> #svnlite revision >>> Path: . >>> Working Copy Root Path: /usr/src >>> URL: svn://svn.freebsd.org/base/head >>> Relative URL: ^/head >>> Repository Root: svn://svn.freebsd.org/base >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> Revision: 352436 >>> Node Kind: directory >>> Schedule: normal >>> Last Changed Author: jah >>> Last Changed Rev: 352434 >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>> >>> root@osboxes:/usr/src # >>> >>> -------------------------------------------- snip ---------------------------- >>> >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> ===> sys (cleandir) >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_kern_tls.h >>> rm: x86: is a directory >>> *** Error code 1 >>> >>> Stop. >>> make[3]: stopped in /usr/src/sys >>> *** Error code 1 >>> >>> Stop. >>> make[2]: stopped in /usr/src >>> *** Error code 1 >>> >>> Stop. >>> make[1]: stopped in /usr/src >>> *** Error code 1 >>> >>> Stop. >>> make: stopped in /usr/src >>> >>> >>> On Tue, Sep 17, 2019 at 6:41 PM vm finance <vm.finance2@gmail.com> wrote: >>> Got it - thank you! >>> >>> btw, I tried to build the patch but its giving an error. Following is SVN info + make error mesg. >>> I have also attached the entire build log...snippet is below >>> >>> Please let me know what am I missing here? >>> >>> Thanks! >>> >>> #svnlite revision >>> Path: . >>> Working Copy Root Path: /usr/src >>> URL: svn://svn.freebsd.org/base/head >>> Relative URL: ^/head >>> Repository Root: svn://svn.freebsd.org/base >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> Revision: 352436 >>> Node Kind: directory >>> Schedule: normal >>> Last Changed Author: jah >>> Last Changed Rev: 352434 >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>> >>> root@osboxes:/usr/src # >>> >>> -------------------------------------------- snip ---------------------------- >>> >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> ===> sys (cleandir) >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_kern_tls.h >>> rm: x86: is a directory >>> *** Error code 1 >>> >>> Stop. >>> make[3]: stopped in /usr/src/sys >>> *** Error code 1 >>> >>> Stop. >>> make[2]: stopped in /usr/src >>> *** Error code 1 >>> >>> Stop. >>> make[1]: stopped in /usr/src >>> *** Error code 1 >>> >>> Stop. >>> make: stopped in /usr/src >>> >>> >>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart <rrs@netflix.com> wrote: >>> Pacing is provided by tcp_hpts.c. The current linux patches do not have >>> to have fq.. they built an alternate means of doing pacing into bbr. >>> >>> In either case our testing has shown that our pacing is more accurate than >>> either fq or the internal pacer :) >>> >>> R >>> >>>> On Sep 17, 2019, at 11:05 AM, vm finance <vm.finance2@gmail.com> wrote: >>>> >>>> Thanks Randall. >>>> I was able to apply the patch - now rebuilding the kernel. Would update on how it goes. >>>> >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is compensated here? >>>> The original BBR patches on Linux show that as a must-have? Is that functionality implemented via tcp_ratelimit.[ch]? >>>> >>>> Any pointers to existing presentations/discussions highly appreciated? >>>> >>>> Thanks a lot. >>>> >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart <rrs@netflix.com> wrote: >>>> You should be able to compile it against the current head. I re-doing that now (had an >>>> issue with my machine and had to roll it back to a backup). >>>> >>>> When I put the patch up on Sept 10th it complied with and without BBR on whatever >>>> was that rev.. >>>> >>>> Looking in the commit logs that would have been around 352191 >>>> >>>> Hope that helps >>>> >>>> R >>>> >>>>> On Sep 17, 2019, at 3:32 AM, vm finance <vm.finance2@gmail.com> wrote: >>>>> >>>>> Hi Randall, >>>>> >>>>> Thanks for releasing BBR patch: >>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >>>>> >>>>> Could you please let me know what SVN/GIT label tag this is based on? I would like to patch and experiment with it. I couldn't find this info in the released patch. >>>>> >>>>> Thanks a lot! >>>>> >>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone <rysto32@gmail.com> wrote: >>>>> rrs@ has just posted the BBR patch to phabricator: >>>>> >>>>> https://reviews.freebsd.org/D21582 >>>> >>>> ------ >>>> Randall Stewart >>>> rrs@netflix.com >>>> >>>> >>>> >>> >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>> >>> >>> >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> > > ------ > Randall Stewart > rrs@netflix.com > > > ------ Randall Stewart rrs@netflix.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5B630235-ABC7-4122-9082-F59BCCCDE14A>