From owner-svn-src-all@FreeBSD.ORG Thu Feb 26 21:36:40 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD09E106566B; Thu, 26 Feb 2009 21:36:40 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 708B18FC21; Thu, 26 Feb 2009 21:36:40 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.local ([192.168.254.200]) (authenticated bits=0) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id n1QLabQE056725; Thu, 26 Feb 2009 14:36:37 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <49A70B65.5090200@samsco.org> Date: Thu, 26 Feb 2009 14:36:37 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Alexander Motin References: <200902262133.n1QLXnt3038889@svn.freebsd.org> In-Reply-To: <200902262133.n1QLXnt3038889@svn.freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r189091 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 21:36:41 -0000 Alexander Motin wrote: > Author: mav > Date: Thu Feb 26 21:33:48 2009 > New Revision: 189091 > URL: http://svn.freebsd.org/changeset/base/189091 > > Log: > Remove direct ata_completed() call options from ata_finish(), except for the > kernel dumping case. > > ata_completed() may initiate ata_reinit() on error, that may lead to drives > attach or detach. Attach and detach are sending requests to drives and sleep > waiting for results. But ata_finish() can be called directly from > interrupt handler where sleeping is prohibited, so we must break this chain > somewhere. This place seems to fit best. > Woo! Scott