From owner-svn-ports-all@FreeBSD.ORG Tue Jan 14 15:24:45 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F41CD52E; Tue, 14 Jan 2014 15:24:44 +0000 (UTC) Received: from mail-qa0-x229.google.com (mail-qa0-x229.google.com [IPv6:2607:f8b0:400d:c00::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7C7E9107E; Tue, 14 Jan 2014 15:24:44 +0000 (UTC) Received: by mail-qa0-f41.google.com with SMTP id w8so2648184qac.14 for ; Tue, 14 Jan 2014 07:24:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=VQ2zz4YEpCFJIPfYxkZTkqGHtcvAx1ugTeiKyyAOPVo=; b=CX906NJQ52I/HQRHMxc22CI28BN64+r9pP7fSdMexC4cgJVN51Ca4O6JuQlbfRRliv LdmdXujIFpgkljuBV9bsvLnJXoTJH4f3oAfQhiOHlkqtJjZVMG7HvYmvymmJfuKn8g76 cREpBDAy+MBKJE7ggUIE3y5IxZ7p+Zu6GCbT7mCghcawZHib4gFYoVG5SwJXNlX1wWUn U8Zps0jd1oC8NcraNejvzMrVCmx4oChnaNd0054DZrhAOZIuBvG1wOPf2p65gFjIFPrA HbHg2LnAocLu0NPVNfOW/+ZR8F+Lz6nW0pj9BnYX3Lb1ye1nslmx6UYmfzbdqD0O7ZF6 1jFw== MIME-Version: 1.0 X-Received: by 10.224.172.9 with SMTP id j9mr3811776qaz.96.1389713083690; Tue, 14 Jan 2014 07:24:43 -0800 (PST) Sender: takatsu.tomonari@gmail.com Received: by 10.96.202.40 with HTTP; Tue, 14 Jan 2014 07:24:43 -0800 (PST) In-Reply-To: <20140114141654.GA47381@FreeBSD.org> References: <201401010649.s016nJ4w004860@svn.freebsd.org> <20140113082949.GB8735@FreeBSD.org> <20140114141654.GA47381@FreeBSD.org> Date: Wed, 15 Jan 2014 00:24:43 +0900 X-Google-Sender-Auth: hUIBLNs2ObTxp11Xn4-E9KV_7KE Message-ID: Subject: Re: svn commit: r338361 - in head/devel/silentbob: . files From: TAKATSU Tomonari To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 15:24:45 -0000 2014/1/14 Alexey Dokuchaev : > On Tue, Jan 14, 2014 at 10:14:19PM +0900, TAKATSU Tomonari wrote: >> 2014/1/13 Alexey Dokuchaev : >> Thank you for pointing out my mistakes. > > Thank you for taking my feedback constructively. > >> -.include >> - > > This hunk is OK. > >> post-patch: >> @${RM} ${WRKSRC}/CMakeCache.txt >> @${REINPLACE_CMD} -e >> 's|/usr/lib/silent_bob/|${PREFIX}/lib/silent_bob/|' \ >> ${WRKSRC}/src/init.cxx > > Here we have a minor problem: REINPLACE_CMD statement is a bit too long, and > causes a line wrap. Would you consider this equivalent, but shorter version > instead: > > @${REINPLACE_CMD} -e '/lib\/silent_bob/s|/usr|${PREFIX}|' \ > ${WRKSRC}/src/init.cxx > > It also is more vocal: for lib/silent_bob, we change /usr into ${PREFIX}, > and reduces duplication ("silent_bob" is spelled only once). > >> post-install: >> @${MKDIR} ${STAGEDIR}${DOCSDIR} >> - @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR} >> -.endif >> + ${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR} > > This part is OK. > > ./danfe Thank you for your advice. I'll commit with the improvement of the REINPLACE_CMD statement. -- TAKATSU Tomonari