From owner-freebsd-ports@freebsd.org  Sun Apr 24 03:24:48 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BE66B118BD
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Sun, 24 Apr 2016 03:24:48 +0000 (UTC) (envelope-from lists@opsec.eu)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 0CCA41AEF
 for <freebsd-ports@freebsd.org>; Sun, 24 Apr 2016 03:24:48 +0000 (UTC)
 (envelope-from lists@opsec.eu)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 0877DB118BC; Sun, 24 Apr 2016 03:24:48 +0000 (UTC)
Delivered-To: ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05E9EB118BB
 for <ports@mailman.ysv.freebsd.org>; Sun, 24 Apr 2016 03:24:48 +0000 (UTC)
 (envelope-from lists@opsec.eu)
Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B2EA11AEE
 for <ports@freebsd.org>; Sun, 24 Apr 2016 03:24:47 +0000 (UTC)
 (envelope-from lists@opsec.eu)
Received: from pi by home.opsec.eu with local (Exim 4.86_2 (FreeBSD))
 (envelope-from <lists@opsec.eu>)
 id 1auAf5-0005JJ-Hd; Sun, 24 Apr 2016 05:24:43 +0200
Date: Sun, 24 Apr 2016 05:24:43 +0200
From: Kurt Jaeger <lists@opsec.eu>
To: Bob Eager <rde@tavi.co.uk>
Cc: ports@freebsd.org
Subject: Re: Best way to submit a port upgrade
Message-ID: <20160424032443.GU2282@home.opsec.eu>
References: <20160424005620.43a31661@raksha.tavi.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160424005620.43a31661@raksha.tavi.co.uk>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Apr 2016 03:24:48 -0000

Hi!

> Background: I have created various ports, but I have never upgraded one
> to a new version (i.e. from a new distfile) before.
> 
> I now have an upgrade to a new version of the port. I have:
> 
> - Updated Makefile
> - Updated pkg-plist
> - Updated distinfo
> - New files in files/
> - New patches in files/
> 
> I am slightly unsure how to submit this. The options seem to be:
> 
> a) A recursive diff (I know about 'port diff').
> b) An svn diff

Both are fine.

> However, what about comments on each of my changes? Should there be
> annotation on what I have done, and how do I specify that in the PR?

There are two change types:

- those that you did to the port itself
  Only if your changes to the port are fancy, it's necessary to explain
  about them.
- those that upstream did to the new version
  If you update from a.b to x.y and the upstream has a changelog,
  please provide a link to that changelog. If there's no linkable
  changelog, please provide a short block of text that explains
  the changes from upstream.

If you put those changes in a comment field in the PR, that's very
nice!

-- 
pi@opsec.eu            +49 171 3101372                         4 years to go !