From owner-freebsd-current Mon Jul 15 14: 1:26 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8D7C37B405 for ; Mon, 15 Jul 2002 14:01:21 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC4E443E31 for ; Mon, 15 Jul 2002 14:01:20 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id HAA05518; Tue, 16 Jul 2002 07:01:15 +1000 Date: Tue, 16 Jul 2002 07:04:46 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Bill Huey Cc: freebsd-current@FreeBSD.ORG Subject: Re: ast() assert failed ? In-Reply-To: <20020715193034.GA1936@gnuppy.monkey.org> Message-ID: <20020716065828.J41957-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 15 Jul 2002, Bill Huey wrote: > I get a billion of these: > > failed to set signal flags proprly for ast() > failed to set signal flags proprly for ast() > failed to set signal flags proprly for ast() > failed to set signal flags proprly for ast() > failed to set signal flags proprly for ast() > failed to set signal flags proprly for ast() > > Is this KSE related ? Maybe. I got a few of these for my original ast() changes an instant after I committed them (long before KSEIII), but haven't been able to duplicate the problem (perhaps because they only occurred for SMP and I rarely run SMP). I use the following change which prints more info and fixes a spelling error (*blush*). %%% Index: subr_trap.c =================================================================== RCS file: /home/ncvs/src/sys/kern/subr_trap.c,v retrieving revision 1.221 diff -u -2 -r1.221 subr_trap.c --- subr_trap.c 11 Jul 2002 02:18:33 -0000 1.221 +++ subr_trap.c 12 Jul 2002 22:05:44 -0000 @@ -82,6 +88,13 @@ mtx_lock_spin(&sched_lock); if (SIGPENDING(p) && ((p->p_sflag & PS_NEEDSIGCHK) == 0 || - (ke->ke_flags & KEF_ASTPENDING) == 0)) - printf("failed to set signal flags proprly for ast()\n"); + (ke->ke_flags & KEF_ASTPENDING) == 0)) { + printf("failed to set signal flags properly for ast()\n"); + printf( + "proc %s sig %#x, sigmask %#x, sigflag %d, astflag %d\n", + p->p_comm, ((int *)&p->p_siglist)[0], + ((int *)&p->p_sigmask)[0], + (p->p_sflag & PS_NEEDSIGCHK) != 0, + (ke->ke_flags & KEF_ASTPENDING) != 0); + } mtx_unlock_spin(&sched_lock); PROC_UNLOCK(p); %%% Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message