Date: Sun, 12 Mar 2017 11:31:31 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r315068 - head/sys/modules/qlxgbe Message-ID: <18e52ee7-0b27-7aff-6b69-75b27673a8f4@FreeBSD.org> In-Reply-To: <20170312124945.C4483@besplex.bde.org> References: <201703111516.v2BFGtkn006959@repo.freebsd.org> <20170312124945.C4483@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/03/2017 04:44, Bruce Evans wrote: > On Sat, 11 Mar 2017, Andriy Gapon wrote: > >> Log: >> revert r314862, use of GCC_MS_EXTENSIONS in qlxgbe >> >> Commit r278913 made explicit use of GCC_MS_EXTENSIONS unnecessary. >> >> Requested by: glebius > > Does this module actually use ms extensions? This seems unlikely, since > only gcc supports them. It probably doesn't. > My kernels compile correctly with the correct CFLAGS (gcc -std=gnu99 > -fno-ms-extensions). How did you manage to pass -std=gnu99 to the module build? No matter what flags I tried to modify the actual compiler invocations still had -std=iso9899:1999 after -std=gnu99 in them, so my modifications had no effect. GCC_MS_EXTENSIONS was the easiest way to get the job done. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18e52ee7-0b27-7aff-6b69-75b27673a8f4>