From nobody Fri Sep 5 21:09:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cJTVv17nfz66Ptx; Fri, 05 Sep 2025 21:09:27 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E6" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cJTVs4NZGz3dSl; Fri, 05 Sep 2025 21:09:25 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=zabbadoz.net header.s=20240622 header.b=LPE98h4D; dmarc=pass (policy=none) header.from=zabbadoz.net; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 2003:a:140a:2200:6:594:fffe:19 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 0945AA64806; Fri, 05 Sep 2025 21:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=zabbadoz.net; s=20240622; t=1757106545; bh=pOb0S8r4WCWR9aHwWE3nsQGjf+/NyeEF9DFjRHoJ9lc=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=LPE98h4D/lfNTU/7MZRafO1p4A0Stny6CTabxKuA01RWOJpm+Nt9c2OFaWzjEW+j8 trZJEbjCRX8zalxb0EEWHIhwkUz6Ir1gwFTFRzq+xE/PfokzwJBlemWD087aCoIfnx LAGDkxGGOMURjMLuoDef0fcRZt68lPSCTf8fEQZIgPCXNVls9/X7+iJZ/tVbZMCRr8 EuBDngnCHl3UZJ1OwvdMa6vuBIKKcuB0n+7EogPG7pUMohxE0fBjHtxEbTlV2kfNNH iZyUlienMYAaibMR+3yzej4u+jPLFJUoJhCYEruilSxl55q4pIbkWOJFZlozE50AIn BhKBHr9R/lKGhsih6F/yPa/vZZEyoLPvj74CduREsTmNxS3/VGplARlJsgAJUqLFSG wRDlR9keLOkaf8F4lPooZL7r5cnKDvQU9OZUuKTXlWgWWEvvXyBoQwmsCY1noB8HpW cEqMR3qNFWscj9fc/y6kYvuCkTVhiLxNQ5Pxe2bTs1GTBxNgSitb/DKfmU8F1fCD/A BbPN/arzddR3rB7Gbsc/vEsH+Mcp8TeM8Rbl6YZKfrWTQ1lkZHgSGfJhpn7WVirYpV y3aqmQtchbRlu3NULK1tsvpFuZN2Oe3PpIDMEMATCKJHVsBCiSeEDlxUDIIFxuLgJU sy0MPIzFQHll183oGExUSO+Q= Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id BCCE32D029E4; Fri, 5 Sep 2025 21:09:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id F4gaHEF2fCt3; Fri, 5 Sep 2025 21:09:11 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:a66b:b6ff:fe40:39a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id C9D802D029D8; Fri, 5 Sep 2025 21:09:11 +0000 (UTC) Date: Fri, 5 Sep 2025 21:09:11 +0000 (UTC) From: "Bjoern A. Zeeb" To: Michael Tuexen cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1c23d8f9f398 - main - vtnet: improve checksum offloading In-Reply-To: <202509041126.584BQBBt067763@gitrepo.freebsd.org> Message-ID: <23rq9r12-75nn-sqs8-06o7-p785s2q915o3@yvfgf.mnoonqbm.arg> References: <202509041126.584BQBBt067763@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.995]; DMARC_POLICY_ALLOW(-0.50)[zabbadoz.net,none]; R_DKIM_ALLOW(-0.20)[zabbadoz.net:s=20240622]; R_SPF_ALLOW(-0.20)[+ip6:2003:a:140a:2200:6:594:fffe:19]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:3320, ipnet:2003::/19, country:DE]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; DKIM_TRACE(0.00)[zabbadoz.net:+] X-Rspamd-Queue-Id: 4cJTVs4NZGz3dSl On Thu, 4 Sep 2025, Michael Tuexen wrote: > The branch main has been updated by tuexen: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1c23d8f9f39870951c1d0dfbb112fc4e53237737 > > commit 1c23d8f9f39870951c1d0dfbb112fc4e53237737 > Author: Michael Tuexen > AuthorDate: 2025-09-04 11:16:46 +0000 > Commit: Michael Tuexen > CommitDate: 2025-09-04 11:16:46 +0000 > > vtnet: improve checksum offloading > > When transmitting a packet over the vtnet interface, map the > csum flags CSUM_DATA_VALID | CSUM_PSEUDO_HDR to the virtio > flag VIRTIO_NET_HDR_F_DATA_VALID. > When receiving a packet over the virtio network channel, translate > the virtio flag VIRTIO_NET_HDR_F_NEEDS_CSUM not to CSUM_DATA_VALID | > CSUM_PSEUDO_HDR, but to CSUM_TCP, CSUM_TCP_IPV6, CSUM_UDP, or > CSUM_UDP_IPV6. > The second change fixes a series of issue related to checksum > offloading for if_vtnet. > While there, improve the stats counters to allow a detailed view > on what is going on in relation to checksum offloading. > > PR: 165059 > Reviewed by: tuexen, manpages > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D51686 This fails to build a LINT-NOIP now. Makes me wonder what good vtnet is in first place w/o INET and w/o INET6? 33 | ^~~~~~~~~~~ 34 1 warning generated. 35 /tank/users/bz/git/FreeBSD/freebsd-src/sys/dev/virtio/network/if_vtnet.c:1825:9: error: call to undeclared function 'in_cksum_skip'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] 36 1825 | csum = in_cksum_skip(m, m->m_pkthdr.len, hdr->csum_start); 37 | ^ 38 /tank/users/bz/git/FreeBSD/freebsd-src/sys/dev/virtio/network/if_vtnet.c:1849:6: error: variable 'hoff' set but not used [-Werror,-Wunused-but-set-variable] 39 1849 | int hoff, protocol; 40 | ^ 41 2 errors generated. 42 --- if_vtnet.o --- 43 *** [if_vtnet.o] Error code 1 > --- > share/man/man4/vtnet.4 | 28 +++-- > sys/dev/virtio/network/if_vtnet.c | 220 ++++++++++++++++++----------------- > sys/dev/virtio/network/if_vtnetvar.h | 2 +- > 3 files changed, 132 insertions(+), 118 deletions(-) > > diff --git a/share/man/man4/vtnet.4 b/share/man/man4/vtnet.4