From owner-cvs-all Thu Aug 23 17:21:24 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 1BD9B37B405; Thu, 23 Aug 2001 17:21:15 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id B28D56ACF0; Fri, 24 Aug 2001 09:51:13 +0930 (CST) Date: Fri, 24 Aug 2001 09:51:13 +0930 From: Greg Lehey To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/i386/conf NOTES src/sys/kern kern_shutdown.c src/sys/sys param.h Message-ID: <20010824095113.E9221@wantadilla.lemis.com> References: <200108232032.f7NKWLB48382@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200108232032.f7NKWLB48382@freefall.freebsd.org>; from jhb@FreeBSD.org on Thu, Aug 23, 2001 at 01:32:21PM -0700 Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thursday, 23 August 2001 at 13:32:21 -0700, John Baldwin wrote: > jhb 2001/08/23 13:32:21 PDT > > Modified files: > sys/conf options > sys/i386/conf NOTES > sys/kern kern_shutdown.c > sys/sys param.h > Log: > Add a new kernel option RESTARTABLE_PANICS. If this option is present, > then one can restart from a panic by resetting the panicstr variable to > NULL. This commit conditionalizes the previously committed functionality > on this variable. It also removes the __dead2 attribute from the panic() > function so that when one continues from a panic() the behavior will > be predictable. The only way I can see to restart from a panic is to enter the debugger and then return, and your code seems to bear this out. Am I missing something? I would think that we can always return from the debugger if we want to continue, and that the RESTARTABLE_PANICS and check for null format string are not necessary. Are you concerned about people who will return from the debugger when they don't mean to? There are plenty of other ways to shoot down the system from the debugger. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message